Skip to content

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jun 19, 2025

Hi all,

Test test/hotspot/jtreg/vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java fails "Out of space in CodeCache" on machine which has huge CPU core number. This test will create lots of compile threads to stress test the compiler deoptimize, the thread number depends on the CPU core number, so on huge CPU core number machine this test will report "Out of space in CodeCache" failure.
The "java.lang.OutOfMemoryError: Out of space in CodeCache" seems not the expected error, and increase the max code cache memory will make this test run pass steady. Could we change ReservedCodeCacheSize from 100m to 200m?

Test-fix only, change has been verified on 256 core number linux-x86 machine and on 64 core number linux-x86 machine.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8359685: Test stress/compiler/deoptimize/Test.java fails Out of space in CodeCache (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25888/head:pull/25888
$ git checkout pull/25888

Update a local copy of the PR:
$ git checkout pull/25888
$ git pull https://git.openjdk.org/jdk.git pull/25888/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25888

View PR using the GUI difftool:
$ git pr show -t 25888

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25888.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 19, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 19, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 19, 2025
@openjdk
Copy link

openjdk bot commented Jun 19, 2025

@sendaoYan The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jun 19, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 19, 2025

Webrevs

@mhaessig
Copy link
Contributor

This looks similar to #25872 which limits the number of compiler threads for high core counts. Would that perhaps already fix this issue or help reduce the amount of code cache needed?

@sendaoYan
Copy link
Member Author

This looks similar to #25872 which limits the number of compiler threads for high core counts. Would that perhaps already fix this issue or help reduce the amount of code cache needed?

Sorry, I didn't noticed that there is already have the same JBS issue. I think I can close this PR and the related JBS issue.

@sendaoYan sendaoYan closed this Jun 19, 2025
@mhaessig
Copy link
Contributor

Sorry, I didn't noticed that there is already have the same JBS issue. I think I can close this PR and the related JBS issue

I don't think it's the exact same issue, but the solution I implemented in the other PR might have an effect on this one.

@sendaoYan sendaoYan deleted the jbs8359685 branch June 19, 2025 12:27
@sendaoYan
Copy link
Member Author

I don't think it's the exact same issue, but the solution I implemented in the other PR might have an effect on this one.

I have verified your implemented manually, it did fix this issue.

@mhaessig
Copy link
Contributor

Oh sorry, I missed that. Good to hear, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants