8359685: Test stress/compiler/deoptimize/Test.java fails Out of space in CodeCache #25888
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
Test test/hotspot/jtreg/vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java fails "Out of space in CodeCache" on machine which has huge CPU core number. This test will create lots of compile threads to stress test the compiler deoptimize, the thread number depends on the CPU core number, so on huge CPU core number machine this test will report "Out of space in CodeCache" failure.
The "java.lang.OutOfMemoryError: Out of space in CodeCache" seems not the expected error, and increase the max code cache memory will make this test run pass steady. Could we change ReservedCodeCacheSize from 100m to 200m?
Test-fix only, change has been verified on 256 core number linux-x86 machine and on 64 core number linux-x86 machine.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25888/head:pull/25888$ git checkout pull/25888Update a local copy of the PR:
$ git checkout pull/25888$ git pull https://git.openjdk.org/jdk.git pull/25888/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25888View PR using the GUI difftool:
$ git pr show -t 25888Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25888.diff
Using Webrev
Link to Webrev Comment