Skip to content

8361754: New test runtime/jni/checked/TestCharArrayReleasing.java can cause disk full errors#26235

Closed
dholmes-ora wants to merge 1 commit intoopenjdk:masterfrom
dholmes-ora:8361754-coredumps
Closed

8361754: New test runtime/jni/checked/TestCharArrayReleasing.java can cause disk full errors#26235
dholmes-ora wants to merge 1 commit intoopenjdk:masterfrom
dholmes-ora:8361754-coredumps

Conversation

@dholmes-ora
Copy link
Copy Markdown
Member

@dholmes-ora dholmes-ora commented Jul 10, 2025

Please review this trivial fix to the test, which needed to set -XX:-CreateCoredumpsOnCrash, after which the exit code is 1 on all platforms.

The test now runs a lot faster too.

Thanks


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8361754: New test runtime/jni/checked/TestCharArrayReleasing.java can cause disk full errors (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26235/head:pull/26235
$ git checkout pull/26235

Update a local copy of the PR:
$ git checkout pull/26235
$ git pull https://git.openjdk.org/jdk.git pull/26235/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26235

View PR using the GUI difftool:
$ git pr show -t 26235

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26235.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Jul 10, 2025

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Jul 10, 2025

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361754: New test runtime/jni/checked/TestCharArrayReleasing.java can cause disk full errors

Reviewed-by: jpai, darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 10, 2025
@openjdk
Copy link
Copy Markdown

openjdk bot commented Jul 10, 2025

@dholmes-ora The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jul 10, 2025
Copy link
Copy Markdown
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK and trivial to me.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 10, 2025
@dholmes-ora
Copy link
Copy Markdown
Member Author

Thanks for the reviews @jaikiran and @jddarcy !

/integrate

@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Jul 10, 2025

Webrevs

@openjdk
Copy link
Copy Markdown

openjdk bot commented Jul 10, 2025

Going to push as commit 2a53f5a.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 10, 2025
@openjdk openjdk bot closed this Jul 10, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 10, 2025
@openjdk
Copy link
Copy Markdown

openjdk bot commented Jul 10, 2025

@dholmes-ora Pushed as commit 2a53f5a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dholmes-ora dholmes-ora deleted the 8361754-coredumps branch July 10, 2025 05:07
@dholmes-ora
Copy link
Copy Markdown
Member Author

/backport jdk jdk25

@openjdk
Copy link
Copy Markdown

openjdk bot commented Jul 10, 2025

@dholmes-ora Could not automatically backport 2a53f5a5 to openjdk/jdk due to conflicts in the following files:

  • test/hotspot/jtreg/runtime/jni/checked/TestCharArrayReleasing.java

Please fetch the appropriate branch/commit and manually resolve these conflicts by using the following commands in your personal fork of openjdk/jdk. Note: these commands are just some suggestions and you can use other equivalent commands you know.

# Fetch the up-to-date version of the target branch
$ git fetch --no-tags https://git.openjdk.org/jdk.git jdk25:jdk25

# Check out the target branch and create your own branch to backport
$ git checkout jdk25
$ git checkout -b backport-dholmes-ora-2a53f5a5-jdk25

# Fetch the commit you want to backport
$ git fetch --no-tags https://git.openjdk.org/jdk.git 2a53f5a5c2544d4f7a77186d99addae110b06bab

# Backport the commit
$ git cherry-pick --no-commit 2a53f5a5c2544d4f7a77186d99addae110b06bab
# Resolve conflicts now

# Commit the files you have modified
$ git add files/with/resolved/conflicts
$ git commit -m 'Backport 2a53f5a5c2544d4f7a77186d99addae110b06bab'

Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk with the title Backport 2a53f5a5c2544d4f7a77186d99addae110b06bab.

Below you can find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 2a53f5a5 from the openjdk/jdk repository.

The commit being backported was authored by David Holmes on 10 Jul 2025 and was reviewed by Jaikiran Pai and Joe Darcy.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants