8362658: sun/security/ssl/SSLEngineImpl/* tests duplicate jvm flags

[Korov]

Hi all,

In the test case, ProcessTools.createTestJavaProcessBuilder(Utils.addTestJavaOpts("SSLEngineKeyLimit", "p", args[1], args[2]));,
ProcessTools.createTestJavaProcessBuilder() will call Utils.prependTestJavaOpts() method, Utils.addTestJavaOpts() will also call Utils.prependTestJavaOpts(), Utils.prependTestJavaOpts() method will execute the following code.

    public static String[] getTestJavaOpts() {
        List<String> opts = new ArrayList<String>();
        Collections.addAll(opts, safeSplitString(VM_OPTIONS));
        Collections.addAll(opts, safeSplitString(JAVA_OPTIONS));
        return opts.toArray(new String[0]);
    }

So the jvm flag will be added repeatedly here, so I removed Utils.addTestJavaOpts().

Just removed duplicate jvm flags, no other changes, risk is low.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8362658: sun/security/ssl/SSLEngineImpl/* tests duplicate jvm flags (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26404/head:pull/26404
$ git checkout pull/26404

Update a local copy of the PR:
$ git checkout pull/26404
$ git pull https://git.openjdk.org/jdk.git pull/26404/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26404

View PR using the GUI difftool:
$ git pr show -t 26404

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26404.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back Korov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@Korov The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (52cb033c)
• 00: Full (931db213)

[rhalade]

Hi @Korov, I appreciate the initiative to have the fix for this bug, but in the future, could we coordinate beforehand if a bug is already assigned to someone else? It helps avoid duplicate work and confusion.

Have you signed the OCA to contribute to OpenJDK? Thanks!