8362658: sun/security/ssl/SSLEngineImpl/* tests duplicate jvm flags

[nehajoshinj]

In this PR we have updated the code to remove the duplicate call and ensure JVM flags are added only once.

ISSUE :-

In the test case --> ProcessTools.createTestJavaProcessBuilder(Utils.addTestJavaOpts("SSLEngineKeyLimit", "p", args[1], args[2]));

-> Before executing ProcessTools.createTestJavaProcessBuilder() we are calling ---> Utils.addTestJavaOpts() which internally call prependTestJavaOpts();

public static String[] addTestJavaOpts(String... userArgs) {
return prependTestJavaOpts(userArgs);
}

-> Then again inside ProcessTools.createTestJavaProcessBuilder() method we are calling Utils.prependTestJavaOpts()

public static ProcessBuilder createTestJavaProcessBuilder(String... command) {
return createJavaProcessBuilder(Utils.prependTestJavaOpts(command));
}

Calling Utils.prependTestJavaOpts() twice leads to duplicate JVM flags (This method call-> getTestJavaOpts() the main reason for duplication and below is the implementation for the same. )

public static String[] getTestJavaOpts() {
List opts = new ArrayList();
Collections.addAll(opts, safeSplitString(VM_OPTIONS));
Collections.addAll(opts, safeSplitString(JAVA_OPTIONS));
return opts.toArray(new String[0]);
}

Contributed-by: @Korov
#26404

https://bugs.openjdk.org/browse/JDK-8362658

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8362658: sun/security/ssl/SSLEngineImpl/* tests duplicate jvm flags (Bug - P4)

Reviewers

• Mikhail Yankelevich (@myankelev - Committer)

Contributors

• Lei Zhu <korov9.c@gmail.com>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28428/head:pull/28428
$ git checkout pull/28428

Update a local copy of the PR:
$ git checkout pull/28428
$ git pull https://git.openjdk.org/jdk.git pull/28428/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28428

View PR using the GUI difftool:
$ git pr show -t 28428

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28428.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back nehajoshinj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@nehajoshinj The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (c641c6ef)
• 02: Full - Incremental (a0cc39e9)
• 01: Full - Incremental (60bc1d76)
• 00: Full (3b6c8d4a)

[mpdonova]

Looks good to me, but try not to overstep the 80 character line-width

[nehajoshinj]

I have updated the code .

[rhalade]

LGTM. Also include an update to remove tests from ProblemList at https://github.com/openjdk/jdk/blob/master/test/jdk/ProblemList-jvmti-stress-agent.txt#L31

[nehajoshinj]

/contributor add @Korov

[openjdk]

@nehajoshinj @Korov was not found in the census.

Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

• /contributor add @openjdk-bot
• /contributor add duke
• /contributor add J. Duke <duke@openjdk.org>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

[nehajoshinj]

/contributor add Lei Zhu korov9.c@gmail.com

[openjdk]

@nehajoshinj
Contributor Lei Zhu <korov9.c@gmail.com> successfully added.

[myankelev]

Looks good to me