8339791: Refactor MiscUndecorated/ActiveAWTWindowTest.java

[srmandal]

The java/awt/Frame/MiscUndecorated/ActiveAWTWindowTest.java test uses object monitors and wait/notify to synchronise actions in the test.

Using CountDownLatch could make the test simpler, shorter, clearer.
Tested the code on a windows-x64, macos-x64 and lnux-x64 machines and the test is working as expected.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8339791: Refactor MiscUndecorated/ActiveAWTWindowTest.java (Bug - P4)

Reviewers

• Prasanta Sadhukhan (@prsadhuk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26471/head:pull/26471
$ git checkout pull/26471

Update a local copy of the PR:
$ git checkout pull/26471
$ git pull https://git.openjdk.org/jdk.git pull/26471/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26471

View PR using the GUI difftool:
$ git pr show -t 26471

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26471.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back smandalika! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@srmandal This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339791: Refactor MiscUndecorated/ActiveAWTWindowTest.java

Reviewed-by: psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1132 new commits pushed to the master branch:

• 90e81c2: 8367616: RISC-V: Auto-enable Zicboz extension for debug builds
• 2425584: 8367142: Avoid InstanceKlass::cast when converting java mirror to InstanceKlass
• 64155df: 8367237: Thread-Safety Usage Warning for java.text.Collator Classes
• ... and 1129 more: https://git.openjdk.org/jdk/compare/9d060574e5dbd13e634f00d749d0108ceff1fae8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kumarabhi006, @prsadhuk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@srmandal The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 05: Full - Incremental (a853dca9)
• 04: Full - Incremental (91c145f1)
• 03: Full - Incremental (bb90ed63)
• 02: Full - Incremental (d766b695)
• 01: Full - Incremental (e7091014)
• 00: Full (eb426f3a)

[srmandal]

Can someone take a quick look and provide feedback on this simple refactoring change ?

[kumarabhi006]

Few more observations :

1. Add a space wherever application. At L76... try {
2. Don't think it is required to print stack trace, you can throw it in RTE.
3. At L165, robot.waitForIdle(5 * delay);
4. Access UI components on EDT. e.g L166 etc.
5. Can remove //captureScreenAndSave(); and System.err.println("Test failed!"); lines

[srmandal]

All Comments have been incorporated.

1. Replaced ExtendedRobot by Robot
2. focusGainLatch usage fixed with an appropriate countDown
3. Replaced Delay*N with actual values.
4. Removed printStackTrace.
5. UI components access restricted to EDT fixed, both initiatiliseGUI, doTest are now static.
6. @OverRide added
7. Also the frame.toFront is now removed, as there is already a mouse click on the frame in the code, which is more reliable and has same effect - for the test scenario.

[srmandal]

I have incorporated the review suggestions. Can anyone provide feedback on these?

[srmandal]

Changed as suggested. All redudant RTEs were removed.

[srmandal]

Removed the passed & eventType variable for test pass/fail assertion.
Tweaked to assert test scenario only on based on latch.
Removed boiler plate code for mouse Move & Click.

I have incorporated the review suggestions. Can anyone provide feedback on these?

[lawrence-andrew]

LGTM

[srmandal]

/integrate

[openjdk]

@srmandal
Your change (at version a853dca) is now ready to be sponsored by a Committer.

[srmandal]

Can some one please sponsor this PR.

[prsadhuk]

/sponsor

[openjdk]

Going to push as commit a306f88.
Since your change was applied there have been 1176 commits pushed to the master branch:

• a355edb: 8367278: Test compiler/startup/StartupOutput.java timed out after completion on Windows
• 91a9794: 8367366: Do not support -XX:+AOTClassLinking for dynamic CDS archive
• aa36799: 8367333: C2: Vector math operation intrinsification failure
• ... and 1173 more: https://git.openjdk.org/jdk/compare/9d060574e5dbd13e634f00d749d0108ceff1fae8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prsadhuk @srmandal Pushed as commit a306f88.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.