JDK-8261839: Error creating runtime package on macos without mac-package-identifier

[andyherrick]

…age-identifier

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8261839: Error creating runtime package on macos without mac-package-identifier

Reviewers

• Alexey Semenyuk (@alexeysemenyukoracle - Committer)
• Alexander Matveev (@sashamatveev - Committer)
• Alexander Zuev (@azuev-java - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2730/head:pull/2730
$ git checkout pull/2730

[bridgekeeper]

👋 Welcome back herrick! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@andyherrick The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (bce75f3)

[alexeysemenyukoracle]

Nice to have runtime packaging implemented on all supported platforms!

[azuev-java]

Looks fine.

[openjdk]

@andyherrick This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261839: Error creating runtime package on macos without mac-package-identifier

Reviewed-by: asemenyuk, almatvee, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 52 new commits pushed to the master branch:

• 4c9adce: 8262379: Add regression test for JDK-8257746
• 6baecf3: 8259937: guarantee(loc != NULL) failed: missing saved register with native invoker
• c569f1d: 8262085: Hovering Metal HTML Tooltips in different windows cause IllegalArgExc on Linux
• 75bf106: 8262028: Make InstanceKlass::implementor return InstanceKlass
• fe8e370: 8262188: Add test to verify trace page sizes logging on Linux
• 0a7fff4: 8261636: The test mapping in hugetlbfs_sanity_check should consider LargePageSizeInBytes
• 702ca62: 8262185: G1: Prune collection set candidates early
• 8bc8542: 8262195: Harden tests that use the HostsFileNameService (jdk.net.hosts.file property)
• 20c93b3: 8261914: IfNode::fold_compares_helper faces non-canonicalized bool when running JRuby JSON workload
• ddd550a: 8261308: C2: assert(inner->is_valid_counted_loop(T_INT) && inner->is_strip_mined()) failed: OuterStripMinedLoop should have been removed
• ... and 42 more: https://git.openjdk.java.net/jdk/compare/2c99bad082c672b2f1b4dc7792c213b2e9076f57...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[andyherrick]

/integrate

[openjdk]

@andyherrick Since your change was applied there have been 53 commits pushed to the master branch:

• 682e120: 8262497: Delete unused utility methods in ICC_Profile class
• 4c9adce: 8262379: Add regression test for JDK-8257746
• 6baecf3: 8259937: guarantee(loc != NULL) failed: missing saved register with native invoker
• c569f1d: 8262085: Hovering Metal HTML Tooltips in different windows cause IllegalArgExc on Linux
• 75bf106: 8262028: Make InstanceKlass::implementor return InstanceKlass
• fe8e370: 8262188: Add test to verify trace page sizes logging on Linux
• 0a7fff4: 8261636: The test mapping in hugetlbfs_sanity_check should consider LargePageSizeInBytes
• 702ca62: 8262185: G1: Prune collection set candidates early
• 8bc8542: 8262195: Harden tests that use the HostsFileNameService (jdk.net.hosts.file property)
• 20c93b3: 8261914: IfNode::fold_compares_helper faces non-canonicalized bool when running JRuby JSON workload
• ... and 43 more: https://git.openjdk.java.net/jdk/compare/2c99bad082c672b2f1b4dc7792c213b2e9076f57...master

Your commit was automatically rebased without conflicts.

Pushed as commit 642f45f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.