8358058: sun/java2d/OpenGL/DrawImageBg.java Test fails intermittently by prrace · Pull Request #27399 · openjdk/jdk

prrace · 2025-09-19T21:53:30Z

Moving to open a number of graphics related tests, originally written to test the OpenGL pipeline.
These versions are "better behaved" than the versions that were in closed - mostly meaning they now
do things on the right thread and paint properly on demand.
As a result they now pass - at least on systems with correct drivers etc.
There are a few bugs to add to the issue list which I'll do right after submitting this.

I also extended these tests so as to run with the default pipeline on every system, not just OpenGL.
This mostly went OK except that I found one of the tests fails on macOS with metal.
I've had to add a new problem listing for that.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8358058: sun/java2d/OpenGL/DrawImageBg.java Test fails intermittently (Bug - P4)

Reviewers

Prasanta Sadhukhan (@prsadhuk - Reviewer) Review applies to e9f78262
Alexander Zvegintsev (@azvegint - Reviewer)
Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27399/head:pull/27399
$ git checkout pull/27399

Update a local copy of the PR:
$ git checkout pull/27399
$ git pull https://git.openjdk.org/jdk.git pull/27399/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27399

View PR using the GUI difftool:
$ git pr show -t 27399

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27399.diff

Using Webrev

Link to Webrev Comment

prrace · 2025-09-19T21:54:25Z

/issue add 8164487,8237245,8297094,8328098,8325761,8358058

bridgekeeper · 2025-09-19T21:55:09Z

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-09-19T21:55:58Z

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358058: sun/java2d/OpenGL/DrawImageBg.java Test fails intermittently

Reviewed-by: azvegint, serb, psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 221 new commits pushed to the master branch:

f740cd2: 8316694: Implement relocation of nmethod within CodeCache
76dba20: 8368821: Test java/net/httpclient/http3/GetHTTP3Test.java intermittently fails with java.io.IOException: QUIC endpoint closed
c3fbbfa: 8369027: Apply java.io.Serial annotations in java.scripting
... and 218 more: https://git.openjdk.org/jdk/compare/3d4e0491940c4b4a05ac84006933d939370e7e2b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-09-19T21:56:41Z

@prrace The issue 8164487 was not found in the JDK project - make sure you have entered it correctly.
The issue 8297094 was not found in the JDK project - make sure you have entered it correctly.
The issue 8328098 was not found in the JDK project - make sure you have entered it correctly.
The issue 8325761 was not found in the JDK project - make sure you have entered it correctly.
The issue 8358058 was not found in the JDK project - make sure you have entered it correctly.
As there were validation problems, no additional issues will be added to the list of solved issues.

openjdk · 2025-09-19T21:57:01Z

@prrace The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

prrace · 2025-09-19T22:14:27Z

/issue add 8164487,8237245,8297094,8328098,8325761,8358058

openjdk · 2025-09-19T22:14:34Z

@prrace The issue 8164487 was not found in the JDK project - make sure you have entered it correctly.
As there were validation problems, no additional issues will be added to the list of solved issues.

prrace · 2025-09-21T06:30:56Z

/issue add 8164487,8237245,8297094,8328098,8325761

openjdk · 2025-09-21T06:31:42Z

@prrace The issue 8164487 was not found in the JDK project - make sure you have entered it correctly.
As there were validation problems, no additional issues will be added to the list of solved issues.

mlbridge · 2025-09-21T06:35:16Z

Webrevs

01: Full - Incremental (932563fb)
00: Full (e9f78262)

mrserb · 2025-09-22T16:20:04Z

why on WIndows/Linux we set "-Dsun.java2d.uiScale=1" option and on mac we do not?

prrace · 2025-09-22T18:22:31Z

why on WIndows/Linux we set "-Dsun.java2d.uiScale=1" option and on mac we do not?

I'd have used uiScale=1 everywhere, but I actually observed a few rounding errors on retina if I used uiScale = 1 .
Letting uiScale be whatever is the default has so far worked on all Mac cases.

mrserb · 2025-09-22T19:46:37Z

why on WIndows/Linux we set "-Dsun.java2d.uiScale=1" option and on mac we do not?

I'd have used uiScale=1 everywhere, but I actually observed a few rounding errors on retina if I used uiScale = 1 . Letting uiScale be whatever is the default has so far worked on all Mac cases.

If it works mostly fine on macos then why it is needed on win/lin?

prsadhuk · 2025-09-23T04:09:46Z

test/jdk/sun/java2d/OpenGL/DrawBufImgOp.java

+ * Graphics2D.drawImage(BufferedImage, BufferedImageOp, x, y) to an
+ * OpenGL-accelerated destination produces the same results when performed
+ * in software via BufferedImageOp.filter().
+ * @run main/othervm -Dsun.java2d.opengl=True -Dsun.java2d.uiScale=1 DrawBufImgOp -ignore


I think since it is failing if we remove ignore and since it is mentioned

/*
* If true, skips tests that are known to trigger bugs (which in
* turn may cause crashes, exceptions, or other artifacts).
*/

my opinion is to remove this param and problemlist this test in failing platform

This is how the test already was. I'm not changing it. I'd be reducing testing if I did this.

prsadhuk

LGTM otherwise

prrace · 2025-09-23T17:48:09Z

why on WIndows/Linux we set "-Dsun.java2d.uiScale=1" option and on mac we do not?

I'd have used uiScale=1 everywhere, but I actually observed a few rounding errors on retina if I used uiScale = 1 . Letting uiScale be whatever is the default has so far worked on all Mac cases.

If it works mostly fine on macos then why it is needed on win/lin?

Because fractional scaling on Windows causes problems too. And Linux we don't scale unless it is 2X and I don't have anything to test that so playing it safe.

mrserb · 2025-09-24T20:56:59Z

Because fractional scaling on Windows causes problems too. And Linux we don't scale unless it is 2X and I don't have anything to test that so playing it safe.

What are problems? Is it a product bug then? Or maybe the tests can use createMultiResolutionScreenCapture to get clean screenshots?

prrace · 2025-09-24T21:59:13Z

I don't think it is a JDK product bug. It is something in Apple's scaling that we can't do anything about.

mrserb · 2025-09-24T22:50:28Z

I don't think it is a JDK product bug. It is something in Apple's scaling that we can't do anything about.

I meant on windows, why it does not work as is, so we need to set scale to 1, the tests seems do not use some complicated colors, patters.

prrace · 2025-09-26T23:26:09Z

I don't think it is a JDK product bug. It is something in Apple's scaling that we can't do anything about.

I meant on windows, why it does not work as is, so we need to set scale to 1, the tests seems do not use some complicated colors, patters.

I removed the -Dsun.java2d.uiScale=1 and ran the tests again - multiple times - on the hidpi system -
and on other platforms, and they still pass.
So I can't reproduce the failure to say what it was that I saw.

So I am going to remove it. And if it ever recurs I will investigate.

azvegint · 2025-10-03T15:17:09Z

test/jdk/sun/java2d/OpenGL/DrawBitmaskImage.java

+ * @test
+ * @bug 6248561 6264014
+ * @key headful
+ * @requires (os.family != "mac")


It looks like we only need one @test statement because they are now identical (besides @requires) after removing uiScale. Same for others.

prrace · 2025-10-07T16:45:16Z

/integrate

openjdk · 2025-10-07T16:47:43Z

Going to push as commit ebeb77b.
Since your change was applied there have been 249 commits pushed to the master branch:

4ca3ab6: 8369123: Still more small Float16 refactorings
eb835e0: 8366040: Change URL.lookupViaProviders to use ScopedValue to detect recursive lookup
eb729f0: 8247776: JFR: TestThreadContextSwitches.java failed "RuntimeException: No events: expected false, was true"
... and 246 more: https://git.openjdk.org/jdk/compare/3d4e0491940c4b4a05ac84006933d939370e7e2b...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-10-07T16:48:06Z

@prrace Pushed as commit ebeb77b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8040230

e9f7826

openjdk bot changed the title ~~8040230~~ 8040230: Sep 19, 2025

openjdk bot added the client client-libs-dev@openjdk.org label Sep 19, 2025

prrace changed the title ~~8040230:~~ 8040230 Sep 19, 2025

openjdk bot changed the title ~~8040230~~ 8040230: Sep 19, 2025

prrace changed the title ~~8040230:~~ 8358058: sun/java2d/OpenGL/DrawImageBg.java Test fails intermittently Sep 21, 2025

openjdk bot added the rfr Pull request is ready for review label Sep 21, 2025

prsadhuk reviewed Sep 23, 2025

View reviewed changes

prsadhuk approved these changes Sep 23, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Sep 23, 2025

8040230

932563f

openjdk bot removed the ready Pull request is ready to be integrated label Sep 26, 2025

azvegint approved these changes Oct 3, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 3, 2025

mrserb approved these changes Oct 5, 2025

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Oct 7, 2025

openjdk bot closed this Oct 7, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 7, 2025

Conversation

prrace commented Sep 19, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

prrace commented Sep 19, 2025

Uh oh!

bridgekeeper bot commented Sep 19, 2025

Uh oh!

openjdk bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Sep 19, 2025

Uh oh!

openjdk bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

prrace commented Sep 19, 2025

Uh oh!

openjdk bot commented Sep 19, 2025

Uh oh!

prrace commented Sep 21, 2025

Uh oh!

openjdk bot commented Sep 21, 2025

Uh oh!

mlbridge bot commented Sep 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

mrserb commented Sep 22, 2025

Uh oh!

prrace commented Sep 22, 2025

Uh oh!

mrserb commented Sep 22, 2025

Uh oh!

prsadhuk Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

prrace Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

prsadhuk left a comment

Choose a reason for hiding this comment

Uh oh!

prrace commented Sep 23, 2025

Uh oh!

mrserb commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

prrace commented Sep 24, 2025

Uh oh!

mrserb commented Sep 24, 2025

Uh oh!

prrace commented Sep 26, 2025

Uh oh!

azvegint Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

prrace commented Oct 7, 2025

Uh oh!

openjdk bot commented Oct 7, 2025

Uh oh!

openjdk bot commented Oct 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

prrace commented Sep 19, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Sep 19, 2025 •

edited

Loading

openjdk bot commented Sep 19, 2025 •

edited

Loading

mlbridge bot commented Sep 21, 2025 •

edited

Loading

mrserb commented Sep 24, 2025 •

edited

Loading