JDK-8353755 : Add a helper method to Util - findComponent() #27944

honkar-jdk · 2025-10-22T22:02:42Z

findComponent(final Container container, final Predicate<Component> predicate) is a useful utility method and thus added to javax/swing/regtesthelpers/Util.java instead of having redundant code in tests. It can be used to find a component by label name.

PS: Existing Util.findSubComponent() finds component by class name but findComponent() can be used to search for a particular component by label name/title when there are multiple subcomponents of same type by applying a predicate logic.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8353755: Add a helper method to Util - findComponent() (Enhancement - P4)

Reviewers

Alexey Ivanov (@aivanov-jdk - Reviewer)
Tejesh R (@TejeshR13 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27944/head:pull/27944
$ git checkout pull/27944

Update a local copy of the PR:
$ git checkout pull/27944
$ git pull https://git.openjdk.org/jdk.git pull/27944/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27944

View PR using the GUI difftool:
$ git pr show -t 27944

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27944.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-10-22T22:03:41Z

👋 Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-10-22T22:05:07Z

@honkar-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353755: Add a helper method to Util - findComponent()

Reviewed-by: aivanov, tr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 302 new commits pushed to the master branch:

c173d41: 8359256: AArch64: Use SHA3 GPR intrinsic where it's faster
3930b1d: 8367982: Unify ObjectSynchronizer and LightweightSynchronizer
093e128: 8347499: C2: Make PhaseIdealLoop eliminate more redundant safepoints in loops
... and 299 more: https://git.openjdk.org/jdk/compare/f84be36dd59ae6b00aea334944b8266ecf8f5cbd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-10-22T22:05:50Z

@honkar-jdk The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-10-22T22:08:47Z

Webrevs

test/jdk/javax/swing/regtesthelpers/Util.java

test/jdk/javax/swing/JFileChooser/FileSizeCheck.java

test/jdk/javax/swing/JFileChooser/bug4759934.java

test/jdk/javax/swing/regtesthelpers/Util.java

test/jdk/javax/swing/JFileChooser/bug4759934.java

test/jdk/javax/swing/JFileChooser/FileSizeCheck.java

prrace · 2025-11-02T17:36:06Z

@TejeshR13 please review

honkar-jdk

@aivanov-jdk
Updated. Please re-review.

test/jdk/javax/swing/regtesthelpers/Util.java

TejeshR13

Any reason for updating the test files with this PR ? I feel this PR should be restricted to Util file updates alone, updating the test files can be taken up separately.

test/jdk/javax/swing/regtesthelpers/Util.java

aivanov-jdk · 2025-11-04T13:36:39Z

test/jdk/javax/swing/JFileChooser/bug4759934.java

            robot.mouseMove(dlgBtnLoc.x , dlgBtnLoc.y);
            robot.mousePress(MouseEvent.BUTTON1_DOWN_MASK);
            robot.mouseRelease(MouseEvent.BUTTON1_DOWN_MASK);
            robot.delay(500);


All the clicks above are to click a button… Should we replace these clicks with programmatic clicks?

However, I'd like to ensure the updated test still reproduces the original bug. Updating this test could better pull out into its own issue. (Yes, I remember that this refactoring comes from an internal comment I made when javax/swing/JFileChooser/bug4759934.java was open-sourced.)

I'll be updating the tests in another PR.

To answer your question.

All the clicks above are to click a button… Should we replace these clicks with programmatic clicks?

I'm for keeping the other clicks as-is (via Robot) since we have reference to these buttons unlike the cancel button of JFileChooser and this way we keep much of the original test case intact without overly modifying it.

aivanov-jdk · 2025-11-04T13:40:19Z

test/jdk/javax/swing/JFileChooser/FileSizeCheck.java

+        Component result = Util.findComponent(container,
+                                         c -> c instanceof JToggleButton button
+                                              && "Details".equals(button.getToolTipText()));


Suggested change

Component result = Util.findComponent(container,

c -> c instanceof JToggleButton button

&& "Details".equals(button.getToolTipText()));

Component result = Util.findComponent(container,

c -> c instanceof JToggleButton button

&& "Details".equals(button.getToolTipText()));

Let's not touch the indentation of the second parameter. The comment below is marked as resolved but it's not resolved. This is what I meant.

That is, only Util. is added, only one line of the findDetailsButton method changes compared to master.

aivanov-jdk · 2025-11-04T13:55:19Z

Any reason for updating the test files with this PR ? I feel this PR should be restricted to Util file updates alone, updating the test files can be taken up separately.

This is a valid concern. I tend to agree. The test from which the findComponent method is moved to the Util class, javax/swing/JFileChooser/FileSizeCheck.java, isn't backported to any releases. Yet I expect this change to Util would be backported to all the supported releases.

This is why I suggest submitting a new bug to update FileSizeCheck.java. (That new bug would be backported to 21u where the test FileSizeCheck.java exists.)

Similarly, as I just mentioned, it makes sense to update javax/swing/JFileChooser/bug4759934.java in its own issue to keep the history clearer. Especially, if we replace all button clicks with programmatic doClick instead of using robot.

honkar-jdk · 2025-11-05T17:59:52Z

@aivanov-jdk As suggested I'll be creating separate PRs for test changes.

test/jdk/javax/swing/regtesthelpers/Util.java

aivanov-jdk

Looks good to me, except for minor formatting nit.

test/jdk/javax/swing/regtesthelpers/Util.java

TejeshR13

LGTM.

honkar-jdk · 2025-11-07T17:45:54Z

/integrate

openjdk · 2025-11-07T17:48:30Z

Going to push as commit 3549103.
Since your change was applied there have been 326 commits pushed to the master branch:

c865644: 8365932: Implementation of JEP 516: Ahead-of-Time Object Caching with Any GC
d5803aa: 8371315: java/foreign/sharedclosejfr/TestSharedCloseJFR.java failed with -XX:-TieredCompilation
167c952: 8371369: Parallel: Relax precondition of PSOldGen::expand_and_allocate
... and 323 more: https://git.openjdk.org/jdk/compare/f84be36dd59ae6b00aea334944b8266ecf8f5cbd...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-11-07T17:48:41Z

@honkar-jdk Pushed as commit 3549103.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

refactoring changes

f803025

openjdk bot added the client client-libs-dev@openjdk.org label Oct 22, 2025

openjdk bot added the rfr Pull request is ready for review label Oct 22, 2025

aivanov-jdk suggested changes Oct 23, 2025

View reviewed changes

review update

6bc9005

aivanov-jdk suggested changes Oct 24, 2025

View reviewed changes

test/jdk/javax/swing/JFileChooser/bug4759934.java Outdated Show resolved Hide resolved

test/jdk/javax/swing/JFileChooser/FileSizeCheck.java Show resolved Hide resolved

Review changes: EDT check

cec6a0c

honkar-jdk commented Nov 3, 2025

View reviewed changes

test/jdk/javax/swing/regtesthelpers/Util.java Show resolved Hide resolved

TejeshR13 reviewed Nov 4, 2025

View reviewed changes

aivanov-jdk suggested changes Nov 4, 2025

View reviewed changes

honkar-jdk added 3 commits November 5, 2025 09:48

Util changes and revert test changes

2d577e8

indentation

0eef08d

indentation

16a3770

aivanov-jdk suggested changes Nov 5, 2025

View reviewed changes

test/jdk/javax/swing/regtesthelpers/Util.java Outdated Show resolved Hide resolved

test/jdk/javax/swing/regtesthelpers/Util.java Show resolved Hide resolved

honkar-jdk added 2 commits November 5, 2025 10:55

review update

c36c7db

revert unchanged lines

1373644

aivanov-jdk approved these changes Nov 5, 2025

View reviewed changes

test/jdk/javax/swing/regtesthelpers/Util.java Outdated Show resolved Hide resolved

openjdk bot added the ready Pull request is ready to be integrated label Nov 5, 2025

This was referenced Nov 6, 2025

JDK-8371364 : Refactor javax/swing/JFileChooser/FileSizeCheck.java to use Util.findComponent() #28168

Closed

JDK-8371365 : Update javax/swing/JFileChooser/bug4759934.java to use Util.findComponent() #28169

Closed

spacing

9bf1926

openjdk bot removed the ready Pull request is ready to be integrated label Nov 6, 2025

TejeshR13 approved these changes Nov 6, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Nov 6, 2025

aivanov-jdk approved these changes Nov 6, 2025

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Nov 7, 2025

openjdk bot closed this Nov 7, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 7, 2025

JDK-8353755 : Add a helper method to Util - findComponent() #27944

JDK-8353755 : Add a helper method to Util - findComponent() #27944

Uh oh!

Conversation

honkar-jdk commented Oct 22, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Oct 22, 2025

Uh oh!

openjdk bot commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mlbridge bot commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

prrace commented Nov 2, 2025

Uh oh!

honkar-jdk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TejeshR13 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aivanov-jdk Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

honkar-jdk Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aivanov-jdk Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

aivanov-jdk commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

honkar-jdk commented Nov 5, 2025

Uh oh!

Uh oh!

Uh oh!

aivanov-jdk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TejeshR13 left a comment

Choose a reason for hiding this comment

Uh oh!

honkar-jdk commented Nov 7, 2025

Uh oh!

openjdk bot commented Nov 7, 2025

Uh oh!

openjdk bot commented Nov 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

honkar-jdk commented Oct 22, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Oct 22, 2025 •

edited

Loading

openjdk bot commented Oct 22, 2025 •

edited

Loading

mlbridge bot commented Oct 22, 2025 •

edited

Loading

honkar-jdk Nov 5, 2025 •

edited

Loading

aivanov-jdk commented Nov 4, 2025 •

edited

Loading