Skip to content

Conversation

@honkar-jdk
Copy link
Contributor

@honkar-jdk honkar-jdk commented Nov 6, 2025

FileSizeCheck.java test changes related to addition of new method to Util - #27944.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371364: Refactor javax/swing/JFileChooser/FileSizeCheck.java to use Util.findComponent() (Task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28168/head:pull/28168
$ git checkout pull/28168

Update a local copy of the PR:
$ git checkout pull/28168
$ git pull https://git.openjdk.org/jdk.git pull/28168/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28168

View PR using the GUI difftool:
$ git pr show -t 28168

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28168.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 6, 2025

👋 Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 6, 2025

@honkar-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371364: Refactor javax/swing/JFileChooser/FileSizeCheck.java to use Util.findComponent()

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Nov 6, 2025
@openjdk
Copy link

openjdk bot commented Nov 6, 2025

@honkar-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 6, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 6, 2025

Webrevs

@honkar-jdk
Copy link
Contributor Author

@aivanov-jdk @TejeshR13 Please review

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 7, 2025
@honkar-jdk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 7, 2025

Going to push as commit 9bc2360.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 7, 2025
@openjdk openjdk bot closed this Nov 7, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 7, 2025
@openjdk
Copy link

openjdk bot commented Nov 7, 2025

@honkar-jdk Pushed as commit 9bc2360.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants