-
Notifications
You must be signed in to change notification settings - Fork 6.2k
JDK-8371364 : Refactor javax/swing/JFileChooser/FileSizeCheck.java to use Util.findComponent() #28168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back honkar! A progress list of the required criteria for merging this PR into |
|
@honkar-jdk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
@honkar-jdk The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
|
@aivanov-jdk @TejeshR13 Please review |
|
/integrate |
|
Going to push as commit 9bc2360. |
|
@honkar-jdk Pushed as commit 9bc2360. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
FileSizeCheck.java test changes related to addition of new method to Util - #27944.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28168/head:pull/28168$ git checkout pull/28168Update a local copy of the PR:
$ git checkout pull/28168$ git pull https://git.openjdk.org/jdk.git pull/28168/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28168View PR using the GUI difftool:
$ git pr show -t 28168Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28168.diff
Using Webrev
Link to Webrev Comment