-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8371205: AArch64: Remove unused cmpxchg* methods #28131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Since JDK-8364406, the AArch64 macroAssembler method cmpxchg_obj_header is no longer used. The method cmpxchgptr is used by cmpxchg_obj_header however is not used by any other method so can be removed alongside cmpxchgptr. cmpxchgw is also unused and can be removed.
|
/contributor add @spchee |
|
👋 Welcome back ruben-arm! A progress list of the required criteria for merging this PR into |
|
@ruben-arm This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 51 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@theRealAph, @kimbarrett, @shqking) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
@ruben-arm Syntax:
User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address. |
|
@ruben-arm The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
/contributor add Samuel Chee samche01@arm.com |
|
@ruben-arm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trivial, obviously correct.
|
/reviewers 1 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
|
@theRealAph |
|
/integrate |
|
@ruben-arm |
|
/sponsor |
|
Going to push as commit c9a9816.
Your commit was automatically rebased without conflicts. |
|
@fg1417 @ruben-arm Pushed as commit c9a9816. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Since JDK-8364406, the AArch64 macroAssembler method cmpxchg_obj_header is no longer used. The method cmpxchgptr is used by cmpxchg_obj_header however is not used by any other method so can be removed alongside cmpxchgptr.
cmpxchgw is also unused and can be removed.
Progress
Issue
Reviewers
Contributors
<samche01@arm.com>Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28131/head:pull/28131$ git checkout pull/28131Update a local copy of the PR:
$ git checkout pull/28131$ git pull https://git.openjdk.org/jdk.git pull/28131/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28131View PR using the GUI difftool:
$ git pr show -t 28131Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28131.diff
Using Webrev
Link to Webrev Comment