Skip to content

Conversation

@ruben-arm
Copy link
Contributor

@ruben-arm ruben-arm commented Nov 4, 2025

Since JDK-8364406, the AArch64 macroAssembler method cmpxchg_obj_header is no longer used. The method cmpxchgptr is used by cmpxchg_obj_header however is not used by any other method so can be removed alongside cmpxchgptr.
cmpxchgw is also unused and can be removed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371205: AArch64: Remove unused cmpxchg* methods (Enhancement - P4)

Reviewers

Contributors

  • Samuel Chee <samche01@arm.com>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28131/head:pull/28131
$ git checkout pull/28131

Update a local copy of the PR:
$ git checkout pull/28131
$ git pull https://git.openjdk.org/jdk.git pull/28131/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28131

View PR using the GUI difftool:
$ git pr show -t 28131

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28131.diff

Using Webrev

Link to Webrev Comment

Since JDK-8364406, the AArch64 macroAssembler method
cmpxchg_obj_header is no longer used. The method cmpxchgptr is used
by cmpxchg_obj_header however is not used by any other method so can
be removed alongside cmpxchgptr.
cmpxchgw is also unused and can be removed.
@ruben-arm
Copy link
Contributor Author

/contributor add @spchee

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 4, 2025

👋 Welcome back ruben-arm! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 4, 2025

@ruben-arm This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371205: AArch64: Remove unused cmpxchg* methods

Co-authored-by: Samuel Chee <samche01@arm.com>
Reviewed-by: aph, kbarrett, haosun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 51 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@theRealAph, @kimbarrett, @shqking) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Nov 4, 2025

@ruben-arm @spchee was not found in the census.

Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Nov 4, 2025
@openjdk
Copy link

openjdk bot commented Nov 4, 2025

@ruben-arm The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 4, 2025
@ruben-arm
Copy link
Contributor Author

/contributor add Samuel Chee samche01@arm.com

@openjdk
Copy link

openjdk bot commented Nov 4, 2025

@ruben-arm
Contributor Samuel Chee <samche01@arm.com> successfully added.

@mlbridge
Copy link

mlbridge bot commented Nov 4, 2025

Webrevs

Copy link
Contributor

@theRealAph theRealAph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial, obviously correct.

@theRealAph
Copy link
Contributor

/reviewers 1

@openjdk
Copy link

openjdk bot commented Nov 4, 2025

⚠️ @ruben-arm the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout pr-8371205
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 4, 2025
@openjdk
Copy link

openjdk bot commented Nov 4, 2025

@theRealAph
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 1 (with at least 1 Reviewer).

@ruben-arm
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 5, 2025
@openjdk
Copy link

openjdk bot commented Nov 5, 2025

@ruben-arm
Your change (at version d87d962) is now ready to be sponsored by a Committer.

@fg1417
Copy link

fg1417 commented Nov 5, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 5, 2025

Going to push as commit c9a9816.
Since your change was applied there have been 51 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 5, 2025
@openjdk openjdk bot closed this Nov 5, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 5, 2025
@openjdk
Copy link

openjdk bot commented Nov 5, 2025

@fg1417 @ruben-arm Pushed as commit c9a9816.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

6 participants