8371383: Test sun/security/tools/jarsigner/DefaultOptions.java failed due to CertificateNotYetValidException

[haimaychao]

The DefaultOptions.java test may fail as the current system time is before the signing certificate NotBefore time, when jarsigner tool validates it in CertificateValidity.valid(). Please review the fix in this test to avoid such intermittent timing problem. Thanks.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8371383: Test sun/security/tools/jarsigner/DefaultOptions.java failed due to CertificateNotYetValidException (Bug - P4)

Reviewers

• Weijun Wang (@wangweij - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28186/head:pull/28186
$ git checkout pull/28186

Update a local copy of the PR:
$ git checkout pull/28186
$ git pull https://git.openjdk.org/jdk.git pull/28186/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28186

View PR using the GUI difftool:
$ git pr show -t 28186

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28186.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back hchao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@haimaychao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371383: Test sun/security/tools/jarsigner/DefaultOptions.java failed due to CertificateNotYetValidException

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 206 new commits pushed to the master branch:

• 45246bc: 8371965: Convert TaskQueueSuper to use Atomic
• 41d6dc3: 8372117: Correct the misleading comment in Character.UnicodeBlock
• 0187f4d: 8372023: Javac JMH failures
• ... and 203 more: https://git.openjdk.org/jdk/compare/e34a831814996be3e0a2df86b11b1718a76ea558...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@haimaychao The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (55c83609)
• 00: Full (606341e3)

[myankelev]

Minor: This is a test issue, could you please remove the bug id from here, as it only tracks product ones?

[haimaychao]

Removed the bug id.

[myankelev]

I wonder if it wouldn't be cleaner to add -startdate -1M to the cert gen instead of sleeping in the test. similar to this pr.

What do you think?

[haimaychao]

Updated code as suggested.

[haimaychao]

/integrate

[openjdk]

Going to push as commit 0972ba6.
Since your change was applied there have been 206 commits pushed to the master branch:

• 45246bc: 8371965: Convert TaskQueueSuper to use Atomic
• 41d6dc3: 8372117: Correct the misleading comment in Character.UnicodeBlock
• 0187f4d: 8372023: Javac JMH failures
• ... and 203 more: https://git.openjdk.org/jdk/compare/e34a831814996be3e0a2df86b11b1718a76ea558...master

Your commit was automatically rebased without conflicts.

[openjdk]

@haimaychao Pushed as commit 0972ba6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.