8345134: Test sun/security/tools/jarsigner/ConciseJarsigner.java failed: unable to find valid certification path to requested target

[myankelev]

Changed the gencert, so the certificate is now initialised to be with a start time of -1M. This prevents a potential error with the certificate not yet being valid.
Similar solution to this pull request
Have tested the test 6000 times for stability and all have passed.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8345134: Test sun/security/tools/jarsigner/ConciseJarsigner.java failed: unable to find valid certification path to requested target (Bug - P4)

Reviewers

• Weijun Wang (@wangweij - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23001/head:pull/23001
$ git checkout pull/23001

Update a local copy of the PR:
$ git checkout pull/23001
$ git pull https://git.openjdk.org/jdk.git pull/23001/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23001

View PR using the GUI difftool:
$ git pr show -t 23001

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23001.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back myankelev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@myankelev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345134: Test sun/security/tools/jarsigner/ConciseJarsigner.java failed: unable to find valid certification path to requested target

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 162 new commits pushed to the master branch:

• 63cedaf: 8347334: JimageDiffGenerator code clean-ups
• 254e840: 8340416: Remove ArchiveBuilder::estimate_archive_size()
• 8193ba3: 8347562: javac crash due to type vars in permits clause
• 7df21a8: 8347597: HttpClient: improve exception reporting when closing connection
• b0e2be6: 8347729: Replace SIZE_FORMAT in parallel and serial gc
• d4e5ec2: 8346610: Make all imports consistent in the FFM API
• c36200b: 8347721: Replace SIZE_FORMAT in compiler directories
• af3f5d8: 8347039: ThreadPerTaskExecutor terminates if cancelled tasks still running
• 91197b3: 8347531: The signal tests are failing after JDK-8345782 due to an unrelated warning
• 4f3dc9d: 8347352: RISC-V: Cleanup bitwise AND assembler routines
• ... and 152 more: https://git.openjdk.org/jdk/compare/f1196638b347c9a2e7d7dc1795c6c24ea7efe711...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@wangweij) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@myankelev The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 04: Full - Incremental (bcc232d9)
• 03: Full - Incremental (065d82c1)
• 02: Full - Incremental (4e03e250)
• 01: Full - Incremental (59d030c2)
• 00: Full (9954e0d4)

[openjdk]

@myankelev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[wangweij]

There are many certificates created in this test. Why are only these 2 lines updated?

[myankelev]

There are many certificates created in this test. Why are only these 2 lines updated?

changed to apply to all certificates if -startdate not specified in the command

[myankelev]

/integrate

[openjdk]

@myankelev
Your change (at version bcc232d) is now ready to be sponsored by a Committer.

[wangweij]

/sponsor

[openjdk]

Going to push as commit a0f7982.
Since your change was applied there have been 162 commits pushed to the master branch:

• 63cedaf: 8347334: JimageDiffGenerator code clean-ups
• 254e840: 8340416: Remove ArchiveBuilder::estimate_archive_size()
• 8193ba3: 8347562: javac crash due to type vars in permits clause
• 7df21a8: 8347597: HttpClient: improve exception reporting when closing connection
• b0e2be6: 8347729: Replace SIZE_FORMAT in parallel and serial gc
• d4e5ec2: 8346610: Make all imports consistent in the FFM API
• c36200b: 8347721: Replace SIZE_FORMAT in compiler directories
• af3f5d8: 8347039: ThreadPerTaskExecutor terminates if cancelled tasks still running
• 91197b3: 8347531: The signal tests are failing after JDK-8345782 due to an unrelated warning
• 4f3dc9d: 8347352: RISC-V: Cleanup bitwise AND assembler routines
• ... and 152 more: https://git.openjdk.org/jdk/compare/f1196638b347c9a2e7d7dc1795c6c24ea7efe711...master

Your commit was automatically rebased without conflicts.

[openjdk]

@wangweij @myankelev Pushed as commit a0f7982.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.