8371682: Suppress javac warning from ThreadPoolExecutorSubclassTest.java

[sendaoYan]

Hi all,

In JDK 11, ThreadPoolExecutor.finalize() was specified to do nothing, leaving the finalize() method empty by JDK-8371748, so I think it's safety to remove finalize() in testFinalizeMethodCallsSuperFinalize for test/jdk/java/util/concurrent/tck/ThreadPoolExecutorSubclassTest.java.

This PR also remove unnecessary '@SuppressWarnings("removal")' in test/jdk/java/util/concurrent/tck/JSR166TestCase.java and test/jdk/java/util/concurrent/tck/ExecutorsTest.java.

Change has been verified locally on linux-x64 by run test java/util/concurrent/tck/JSR166TestCase.java#default. Test-fix only, no risk,

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8371682: Suppress javac warning from ThreadPoolExecutorSubclassTest.java (Bug - P5)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28278/head:pull/28278
$ git checkout pull/28278

Update a local copy of the PR:
$ git checkout pull/28278
$ git pull https://git.openjdk.org/jdk.git pull/28278/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28278

View PR using the GUI difftool:
$ git pr show -t 28278

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28278.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371682: Suppress javac warning from ThreadPoolExecutorSubclassTest.java

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 56 new commits pushed to the master branch:

• 69e3024: 8349157: Unnecessary Hashtable usage in XKeysym.javaKeycode2KeysymHash
• 970533d: 8371779: Replace MemTagBitmap with ResourceBitMap
• d032b28: 8371894: Minor style fixes in AOT/CDS code
• ... and 53 more: https://git.openjdk.org/jdk/compare/676e6fd8d5152f4e0d14ae59ddd7aa0a7127ea58...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@sendaoYan The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (3c57f3bc)
• 00: Full (374c8ef8)

[AlanBateman]

I think the changes in this PR are okay. I think it is time to remove TPE.finalize too (not this PR of course).

[SirYwell]

What does testFinalizeMethodCallsSuperFinalize test now?

[sendaoYan]

What does testFinalizeMethodCallsSuperFinalize test now?

I have verified java/util/concurrent/tck/JSR166TestCase.java#default locally, test still run passed. Test java/util/concurrent/tck/JSR166TestCase.java#default will invoke all the junit tests in java/util/concurrent/tck directory.

[bchristi-git]

I think it is time to remove TPE.finalize too

FYI, I've submitted a PR to do this:
https://git.openjdk.org/jdk/pull/28311

[jaikiran]

The changes look good to me but I think Hannes' question is valid.

What does testFinalizeMethodCallsSuperFinalize test now?

I have verified java/util/concurrent/tck/JSR166TestCase.java#default locally, test still run passed. Test java/util/concurrent/tck/JSR166TestCase.java#default will invoke all the junit tests in java/util/concurrent/tck directory.

Is the testFinalizeMethodCallsSuperFinalize() needed or can it be removed? With the changes in this PR, I don't see what this method tests, especially given its name. It's a different matter that even without the changes to this PR, I am not sure what was being tested/asserted in that test method.

[sendaoYan]

The changes look good to me but I think Hannes' question is valid.

What does testFinalizeMethodCallsSuperFinalize test now?

I have verified java/util/concurrent/tck/JSR166TestCase.java#default locally, test still run passed. Test java/util/concurrent/tck/JSR166TestCase.java#default will invoke all the junit tests in java/util/concurrent/tck directory.

Is the testFinalizeMethodCallsSuperFinalize() needed or can it be removed? With the changes in this PR, I don't see what this method tests, especially given its name. It's a different matter that even without the changes to this PR, I am not sure what was being tested/asserted in that test method.

Sorry, I get the questions now.

Test testFinalizeMethodCallsSuperFinalize was added by JDK-8190324. Since #28278 will remove the (empty) ThreadPoolExecutor.finalize() method, so testFinalizeMethodCallsSuperFinalize can be removed also.

[jaikiran]

The change looks good to me. I'll let you decide with others on the other PR #28311 whether the testFinalizeMethodCallsSuperFinalize test method removal should be part of this PR or the other one.

[sendaoYan]

Besides remove the testFinalizeMethodCallsSuperFinalize, this PR also remove two unnecessary '@SuppressWarnings("removal")'. So I think it's suitable integrate this PR standalone before #28311.

Thanks all for the reviews.

/integrate

[openjdk]

Going to push as commit 44087ea.
Since your change was applied there have been 63 commits pushed to the master branch:

• 960987e: 8371991: Build failure in docs for MemoryMXBean
• 8301d99: 8371825: G1: Use more precise filler API in fill_range_with_dead_objects
• cebb03e: 8371349: Update NSS library to 3.117
• ... and 60 more: https://git.openjdk.org/jdk/compare/676e6fd8d5152f4e0d14ae59ddd7aa0a7127ea58...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sendaoYan Pushed as commit 44087ea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.