Skip to content

Conversation

@Anjian-Wen
Copy link
Contributor

@Anjian-Wen Anjian-Wen commented Nov 14, 2025

Support AES CBC intrinsic on RISCV, Already passed the tests in
test/hotspot/jtreg/compiler/codegen/aes/
test/jdk/com/sun/crypto


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371968: RISC-V: implement AES CBC intrinsics (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28320/head:pull/28320
$ git checkout pull/28320

Update a local copy of the PR:
$ git checkout pull/28320
$ git pull https://git.openjdk.org/jdk.git pull/28320/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28320

View PR using the GUI difftool:
$ git pr show -t 28320

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28320.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 14, 2025

👋 Welcome back wenanjian! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 14, 2025

@Anjian-Wen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371968: RISC-V: implement AES CBC intrinsics

Reviewed-by: fyang, fjiang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang, @feilongjiang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Nov 14, 2025
@openjdk
Copy link

openjdk bot commented Nov 14, 2025

@Anjian-Wen The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@Anjian-Wen
Copy link
Contributor Author

/issue JDK-8371968

@openjdk openjdk bot changed the title RISC-V: implement AES CBC mode intrinsics 8371968: RISC-V: implement AES CBC intrinsics Nov 17, 2025
@openjdk
Copy link

openjdk bot commented Nov 17, 2025

@Anjian-Wen The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

@Anjian-Wen Anjian-Wen marked this pull request as ready for review November 24, 2025 03:42
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 24, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 24, 2025

Webrevs

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Thanks for making the changes. I am having a look.

@Anjian-Wen Anjian-Wen marked this pull request as draft December 5, 2025 03:13
@openjdk openjdk bot removed the rfr Pull request is ready for review label Dec 5, 2025
@Anjian-Wen Anjian-Wen marked this pull request as ready for review December 5, 2025 03:19
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 5, 2025
Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Two comments remain.

Copy link
Member

@feilongjiang feilongjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest version looks good. Thanks.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 9, 2025
@Anjian-Wen
Copy link
Contributor Author

@RealFYang @feilongjiang Thanks for the review!

@Anjian-Wen
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 10, 2025
@openjdk
Copy link

openjdk bot commented Dec 10, 2025

@Anjian-Wen
Your change (at version 6828d5e) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 10, 2025

Going to push as commit a5968f9.
Since your change was applied there have been 50 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 10, 2025
@openjdk openjdk bot closed this Dec 10, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 10, 2025
@openjdk
Copy link

openjdk bot commented Dec 10, 2025

@RealFYang @Anjian-Wen Pushed as commit a5968f9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants