8352654: [REDO] nsk/jvmti/ tests should fail when nsk_jvmti_setFailStatus() is called

[lmesnik]

Please review second attempt to fail tests right in the nsk_jvmti_setFailStatus().

I run jvmti tests with different options and probelmlisted the only failing tests.

The previous attempt uncover a lot of problems related to the
JDK-8355631
The events might be generated after VM_DEATH event

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8352654: [REDO] nsk/jvmti/ tests should fail when nsk_jvmti_setFailStatus() is called (Bug - P4)

Reviewers

• Alex Menkov (@alexmenkov - Reviewer)
• Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28404/head:pull/28404
$ git checkout pull/28404

Update a local copy of the PR:
$ git checkout pull/28404
$ git pull https://git.openjdk.org/jdk.git pull/28404/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28404

View PR using the GUI difftool:
$ git pr show -t 28404

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28404.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352654: [REDO] nsk/jvmti/ tests should fail when  nsk_jvmti_setFailStatus() is called

Reviewed-by: amenkov, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 110 new commits pushed to the master branch:

• 6e920fb: 8372380: Make hs_err reporting more robust for unattached threads
• c028369: 8350938: ResourceParsingClassHierarchyResolver inflates all Utf8 CP entries
• 10ba0ab: 8371637: allocateNativeInternal sometimes return incorrectly aligned memory
• ... and 107 more: https://git.openjdk.org/jdk/compare/1535d08f0ee5da42d9db9e196d6a620aabe9feea...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@lmesnik The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (cc51aef8)
• 00: Full (e4994574)

[alexmenkov]

Need to update copyright yer in agent_tools.cpp
Did you tested it with tiers5-7?

[lmesnik]

Need to update copyright yer in agent_tools.cpp Did you tested it with tiers5-7?

It looks too much overhead to run whole tier5-7 for test fix. So I run nsk/jvmti tests with options from our CI. I grabbed all possible VM flags, hope that I didn't missed anything.

[sspitsyn]

It looks too much overhead to run whole tier5-7 for test fix. I grabbed all possible VM flags, hope that I didn't missed anything.

It feels that it would be more safe to run mach5 tiers 1-6. It is not that big overhead for avoiding risk of regressions, especially at this phase of development.

[lmesnik]

/integrate

[openjdk]

Going to push as commit 847fbab.
Since your change was applied there have been 111 commits pushed to the master branch:

• 42db9ab: 8298432: Investigate the benefits of usage of GetPrimitiveArrayCritical in the cmm code
• 6e920fb: 8372380: Make hs_err reporting more robust for unattached threads
• c028369: 8350938: ResourceParsingClassHierarchyResolver inflates all Utf8 CP entries
• ... and 108 more: https://git.openjdk.org/jdk/compare/1535d08f0ee5da42d9db9e196d6a620aabe9feea...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lmesnik Pushed as commit 847fbab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.