Store end positions directly in JCTree #28506
Closed
+126
−556
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prototype of storing end positions in a field in JCTree, instead of in a separate
EndPosTable.See this compiler-dev@ thread.
Progress
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28506/head:pull/28506$ git checkout pull/28506Update a local copy of the PR:
$ git checkout pull/28506$ git pull https://git.openjdk.org/jdk.git pull/28506/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28506View PR using the GUI difftool:
$ git pr show -t 28506Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28506.diff