8372993: Serial: max_eden_size is too small after JDK-8368740

[jsikstro]

Hello,

_max_eden_size does not represent the actual upper-limit of how large eden might grow. The upper-limit was changed in JDK-8368740, so that eden might now grow to be almost as large as the entire young generation. We run into an exception when trying to use this value through the MemoryUsage Java API. If the committed memory in eden is larger than _max_eden_size, we throw an exception in the Java constructor of MemoryUsage: https://github.com/openjdk/jdk/blob/master/src/java.management/share/classes/java/lang/management/MemoryUsage.java#L165-L168

Testing:

• Oracle's tier1-4

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8372993: Serial: max_eden_size is too small after JDK-8368740 (Bug - P4)

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Axel Boldt-Christmas (@xmas92 - Reviewer)
• Stefan Karlsson (@stefank - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28630/head:pull/28630
$ git checkout pull/28630

Update a local copy of the PR:
$ git checkout pull/28630
$ git pull https://git.openjdk.org/jdk.git pull/28630/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28630

View PR using the GUI difftool:
$ git pr show -t 28630

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28630.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jsikstro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jsikstro This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372993: Serial: max_eden_size is too small after JDK-8368740

Reviewed-by: ayang, aboldtch, stefank

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 135661b: 8372179: Remove Unused ConcurrentHashTable::MultiGetHandle
• afb6a0c: 8372958: SocketInputStream.read throws SocketException instead of returning -1 when input shutdown
• abb75ba: 8372587: Put jdk/jfr/jvm/TestWaste.java into the ProblemList
• ... and 5 more: https://git.openjdk.org/jdk/compare/f1a4d1bfde652cf758117b93bbd02ae8248e805e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jsikstro The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (db987454)
• 01: Full - Incremental (b01fb981)
• 00: Full (00b085ff)

[xmas92]

Looks good.

[jsikstro]

Thank you for the reviews @albertnetymk @xmas92 @stefank
/integrate

[openjdk]

Going to push as commit c063673.
Since your change was applied there have been 8 commits pushed to the master branch:

• 135661b: 8372179: Remove Unused ConcurrentHashTable::MultiGetHandle
• afb6a0c: 8372958: SocketInputStream.read throws SocketException instead of returning -1 when input shutdown
• abb75ba: 8372587: Put jdk/jfr/jvm/TestWaste.java into the ProblemList
• ... and 5 more: https://git.openjdk.org/jdk/compare/f1a4d1bfde652cf758117b93bbd02ae8248e805e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jsikstro Pushed as commit c063673.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.