Skip to content

Conversation

@jsikstro
Copy link
Member

@jsikstro jsikstro commented Dec 3, 2025

Hello,

We backed out this change in #28617 after issues in found in testing. Moving forward, we've decided to problem list a few tests that assumes that a GC does not run during their execution. When the initial heap size becomes very low with this change, it may trigger additional GCs, which may interfere with a few tests.

We are planning to follow up on the problem lists with test fixes in:
#28638, #28637

From the original RFE:

This RFE changes the default of InitialRAMPercentage to 0, effectively removing its default value. Please see the CSR for specific details on this change.

Changing the default value to 0 results in the behavior that the initial heap size (InitialHeapSize) is set to the minimum heap size (MinHeapSize). This is because of the following lines in Arguments::set_heap_size(), which takes the MAX value of MinHeapSize as well:

uint64_t initial_memory = (uint64_t)(((double)MaxRAM * InitialRAMPercentage) / 100);
...

reasonable_initial = MAX3(reasonable_initial, reasonable_minimum, MinHeapSize);
reasonable_initial = MIN2(reasonable_initial, MaxHeapSize);

This change improves startup performance for all GCs, but affects the time-to-peak performance in some out-of-the-box configurations for some GCs. This is mainly visible in ParallelGC.

Testing:

  • Oracle's tier1-3

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8371987 to be approved

Issues

  • JDK-8373023: [REDO] Remove the default value of InitialRAMPercentage (Enhancement - P4)
  • JDK-8371987: Remove the default value of InitialRAMPercentage (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28641/head:pull/28641
$ git checkout pull/28641

Update a local copy of the PR:
$ git checkout pull/28641
$ git pull https://git.openjdk.org/jdk.git pull/28641/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28641

View PR using the GUI difftool:
$ git pr show -t 28641

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28641.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 3, 2025

👋 Welcome back jsikstro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 3, 2025

@jsikstro This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373023: [REDO] Remove the default value of InitialRAMPercentage

Reviewed-by: stefank, sjohanss, aboldtch

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • c432150: 8372809: Test vmTestbase/nsk/jdi/ThreadReference/isSuspended/issuspended001/TestDescription.java failed: JVMTI_ERROR_THREAD_NOT_ALIVE

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Dec 3, 2025
@openjdk
Copy link

openjdk bot commented Dec 3, 2025

@jsikstro The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 3, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 3, 2025

Webrevs

# jdk_jdi

com/sun/jdi/InvokeHangTest.java 8218463 linux-all
com/sun/jdi/MethodInvokeWithTraceOnTest.java 8373022 generic-all
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about java/lang/management/MemoryPoolMXBean/ThresholdTest.java, that was the test that started failing for me yesterday.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test failure in java/lang/management/MemoryPoolMXBean/ThresholdTest.java is fixed in #28630

This was a pre-existing issue that is not directly tied to this change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I didn't see that change go by.

@jsikstro jsikstro force-pushed the JDK-8373023_iramp0_redo branch from 03bdb9e to 6a3510b Compare December 3, 2025 16:25
Copy link
Contributor

@kstefanj kstefanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@openjdk
Copy link

openjdk bot commented Dec 3, 2025

@jsikstro Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@jsikstro
Copy link
Member Author

jsikstro commented Dec 3, 2025

Thank you for the reviews everyone!
/integrate

@openjdk
Copy link

openjdk bot commented Dec 3, 2025

Going to push as commit 8d80778.
Since your change was applied there have been 3 commits pushed to the master branch:

  • fa6ca0b: 8362428: Update IANA Language Subtag Registry to Version 2025-08-25
  • 0bcef61: 8372957: After JDK-8282441 JDWP might allow some invalid FrameIDs to be used
  • c432150: 8372809: Test vmTestbase/nsk/jdi/ThreadReference/isSuspended/issuspended001/TestDescription.java failed: JVMTI_ERROR_THREAD_NOT_ALIVE

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 3, 2025
@openjdk openjdk bot closed this Dec 3, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 3, 2025
@openjdk
Copy link

openjdk bot commented Dec 3, 2025

@jsikstro Pushed as commit 8d80778.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

5 participants