8373097: Save command should create missing parent directories

[sormuras]

Please review this change enhancing the /save <file> command in JShell to create missing parent directories.

Prior to this change, when the argument of a /save command starts with a list of directory names, of which at least one does not exist, the command fails with an exception reading:

/save some/path/Snippet.java
| File 'some/path/Snippet.java' for '/save' threw exception: java.nio.file.NoSuchFileException: some\path\Snippet.java

Any exception happening during the creation of missing parent directories (using Files.createDirectories API) is caught and transformed into file-related error message.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8373097: Save command should create missing parent directories (Enhancement - P4)

Reviewers

• Jan Lahoda (@lahodaj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28662/head:pull/28662
$ git checkout pull/28662

Update a local copy of the PR:
$ git checkout pull/28662
$ git pull https://git.openjdk.org/jdk.git pull/28662/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28662

View PR using the GUI difftool:
$ git pr show -t 28662

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28662.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sormuras This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373097: Save command should create missing parent directories

Reviewed-by: jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 151 new commits pushed to the master branch:

• e635330: 8373069: RISC-V: implement GHASH intrinsic
• 3f07710: 8373441: Remove DCmdFactory::_enabled
• 87d881f: 8368493: Disable most test JSSE debug output by default, and increase the test default maximum output log size
• ... and 148 more: https://git.openjdk.org/jdk/compare/c55287d197ef024033f8dfbb5a365cb091bc67fb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@sormuras The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

@sormuras Unknown command save - for a list of valid commands use /help.

[mlbridge]

Webrevs

• 00: Full (668701df)

[lahodaj]

Looks good to me, thanks!

[sormuras]

/integrate

[openjdk]

Going to push as commit e9b4696.
Since your change was applied there have been 151 commits pushed to the master branch:

• e635330: 8373069: RISC-V: implement GHASH intrinsic
• 3f07710: 8373441: Remove DCmdFactory::_enabled
• 87d881f: 8368493: Disable most test JSSE debug output by default, and increase the test default maximum output log size
• ... and 148 more: https://git.openjdk.org/jdk/compare/c55287d197ef024033f8dfbb5a365cb091bc67fb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sormuras Pushed as commit e9b4696.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.