Skip to content

8373246: JDK-8351842 broke native debugging on Linux#28699

Closed
tstuefe wants to merge 1 commit intoopenjdk:masterfrom
tstuefe:JDK-8373246-JDK-8351842-broke-native-debugging-on-Linux
Closed

8373246: JDK-8351842 broke native debugging on Linux#28699
tstuefe wants to merge 1 commit intoopenjdk:masterfrom
tstuefe:JDK-8373246-JDK-8351842-broke-native-debugging-on-Linux

Conversation

@tstuefe
Copy link
Copy Markdown
Member

@tstuefe tstuefe commented Dec 8, 2025

Simple fix to restore debuginfo files to their proper places in the images.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8373246: JDK-8351842 broke native debugging on Linux (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28699/head:pull/28699
$ git checkout pull/28699

Update a local copy of the PR:
$ git checkout pull/28699
$ git pull https://git.openjdk.org/jdk.git pull/28699/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28699

View PR using the GUI difftool:
$ git pr show -t 28699

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28699.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Dec 8, 2025

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Dec 8, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the build build-dev@openjdk.org label Dec 8, 2025
@openjdk
Copy link
Copy Markdown

openjdk bot commented Dec 8, 2025

@tstuefe The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@tstuefe tstuefe marked this pull request as ready for review December 8, 2025 13:11
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 8, 2025
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Dec 8, 2025

Webrevs

Copy link
Copy Markdown
Member

@erikj79 erikj79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would break JDK-8351842. I think if JDK-8351842 was made under bad assumptions, it should be backed out and reworked.

@tstuefe
Copy link
Copy Markdown
Member Author

tstuefe commented Dec 8, 2025

This would break JDK-8351842. I think if JDK-8351842 was made under bad assumptions, it should be backed out and reworked.

Okay, then I am also in favor of reverting JDK-8351842 and doing that patch under a new header. The title "Windows specific issues..." for JDK-8351842 is quite misleading if it changes behavior for all platforms.

Imho, a debug build, done with default options, should be debuggable with a debugger invoked on the produced binary with default options.

Okay, I'll close this PR. @RealCLanger can you please look into this, possibly revert and rework?

@tstuefe tstuefe closed this Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build build-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants