8373246: JDK-8351842 broke native debugging on Linux#28699
8373246: JDK-8351842 broke native debugging on Linux#28699tstuefe wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
erikj79
left a comment
There was a problem hiding this comment.
This would break JDK-8351842. I think if JDK-8351842 was made under bad assumptions, it should be backed out and reworked.
Okay, then I am also in favor of reverting JDK-8351842 and doing that patch under a new header. The title "Windows specific issues..." for JDK-8351842 is quite misleading if it changes behavior for all platforms. Imho, a debug build, done with default options, should be debuggable with a debugger invoked on the produced binary with default options. Okay, I'll close this PR. @RealCLanger can you please look into this, possibly revert and rework? |
Simple fix to restore debuginfo files to their proper places in the images.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28699/head:pull/28699$ git checkout pull/28699Update a local copy of the PR:
$ git checkout pull/28699$ git pull https://git.openjdk.org/jdk.git pull/28699/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28699View PR using the GUI difftool:
$ git pr show -t 28699Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28699.diff
Using Webrev
Link to Webrev Comment