Skip to content

8373207: Make DeferredStatic class template constant initializable#28710

Closed
kimbarrett wants to merge 1 commit intoopenjdk:masterfrom
kimbarrett:constinit-deferredstatic
Closed

8373207: Make DeferredStatic class template constant initializable#28710
kimbarrett wants to merge 1 commit intoopenjdk:masterfrom
kimbarrett:constinit-deferredstatic

Conversation

@kimbarrett
Copy link

@kimbarrett kimbarrett commented Dec 8, 2025

Please review this change to DeferredStatic to meet the requirements for
constant initialization, to ensure dynamic initialization won't even be
considered a possibility.

Testing: mach5 tier1.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8373207: Make DeferredStatic class template constant initializable (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28710/head:pull/28710
$ git checkout pull/28710

Update a local copy of the PR:
$ git checkout pull/28710
$ git pull https://git.openjdk.org/jdk.git pull/28710/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28710

View PR using the GUI difftool:
$ git pr show -t 28710

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28710.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 8, 2025

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 8, 2025

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373207: Make DeferredStatic class template constant initializable

Reviewed-by: jsjolen, stefank, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Dec 8, 2025
@openjdk
Copy link

openjdk bot commented Dec 8, 2025

@kimbarrett The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 8, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 8, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 9, 2025
@kimbarrett
Copy link
Author

Thanks for reviews @jdksjolen , @stefank , and @walulyai

@kimbarrett
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 10, 2025

Going to push as commit 7f9951a.
Since your change was applied there have been 21 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 10, 2025
@openjdk openjdk bot closed this Dec 10, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 10, 2025
@openjdk
Copy link

openjdk bot commented Dec 10, 2025

@kimbarrett Pushed as commit 7f9951a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kimbarrett kimbarrett deleted the constinit-deferredstatic branch December 10, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants