8373517: Revert the macos Tahoe specific change done in JDK-8359830#28768
8373517: Revert the macos Tahoe specific change done in JDK-8359830#28768jaikiran wants to merge 3 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back jpai! A progress list of the required criteria for merging this PR into |
|
@jaikiran This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
Thank you Roger and Brian for the reviews. |
|
/integrate |
|
Going to push as commit 325cdb7.
Your commit was automatically rebased without conflicts. |
Can I please get a review of this change which reverts the macos Tahoe specific change we had done in https://bugs.openjdk.org/browse/JDK-8359830? As noted in https://bugs.openjdk.org/browse/JDK-8373517, Apple addressed the underlying issue in a 26.0 Beta release and we no longer require this change in the JDK.
The revert in this PR was done with a
git revertof 8df6b2c. That original commit had updated a jtreg test to verify theos.versionsystem property reported by the JDK on macos. The commit in this PR retains that test because it's useful even without the source changes done in that older commit.tier1, tier2 and tier3 testing of this change completed without any related issues. I've verified that macos 26.x was one of the hosts that was picked up in those test runs.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28768/head:pull/28768$ git checkout pull/28768Update a local copy of the PR:
$ git checkout pull/28768$ git pull https://git.openjdk.org/jdk.git pull/28768/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28768View PR using the GUI difftool:
$ git pr show -t 28768Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28768.diff
Using Webrev
Link to Webrev Comment