8373627: assert(!is_vthread_transition_disabler()) failed: no suspend allowed for vthread transition disablers#28805
8373627: assert(!is_vthread_transition_disabler()) failed: no suspend allowed for vthread transition disablers#28805sspitsyn wants to merge 1 commit intoopenjdk:masterfrom
Conversation
… allowed for vthread transition disablers
|
👋 Welcome back sspitsyn! A progress list of the required criteria for merging this PR into |
|
@sspitsyn This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 121 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
pchilano
left a comment
There was a problem hiding this comment.
Thanks for finding and fixing this Serguei!
|
Thank you for reviews, David and Patricio! |
|
/integrate |
|
Going to push as commit 53ebcdb.
Your commit was automatically rebased without conflicts. |
|
/backport :jdk26 |
|
@sspitsyn the backport was successfully created on the branch backport-sspitsyn-53ebcdbd-jdk26 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk26, just click the following link: The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:
If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk: |
This is a 1-liner fix of a regression.
The issue was discovered after merge with main line of this PR: #28407 .
It will need to be back ported to 26 as well.
Testing:
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28805/head:pull/28805$ git checkout pull/28805Update a local copy of the PR:
$ git checkout pull/28805$ git pull https://git.openjdk.org/jdk.git pull/28805/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28805View PR using the GUI difftool:
$ git pr show -t 28805Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28805.diff
Using Webrev
Link to Webrev Comment