Skip to content

8373627: assert(!is_vthread_transition_disabler()) failed: no suspend allowed for vthread transition disablers#28805

Closed
sspitsyn wants to merge 1 commit intoopenjdk:masterfrom
sspitsyn:f9
Closed

8373627: assert(!is_vthread_transition_disabler()) failed: no suspend allowed for vthread transition disablers#28805
sspitsyn wants to merge 1 commit intoopenjdk:masterfrom
sspitsyn:f9

Conversation

@sspitsyn
Copy link
Copy Markdown
Contributor

@sspitsyn sspitsyn commented Dec 12, 2025

This is a 1-liner fix of a regression.
The issue was discovered after merge with main line of this PR: #28407 .

It will need to be back ported to 26 as well.

Testing:

  • TBD: This was already tested in another PR repo but will submit mach5 tiers 1-3 to be completely safe.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8373627: assert(!is_vthread_transition_disabler()) failed: no suspend allowed for vthread transition disablers (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28805/head:pull/28805
$ git checkout pull/28805

Update a local copy of the PR:
$ git checkout pull/28805
$ git pull https://git.openjdk.org/jdk.git pull/28805/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28805

View PR using the GUI difftool:
$ git pr show -t 28805

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28805.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Dec 12, 2025

👋 Welcome back sspitsyn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Dec 12, 2025

@sspitsyn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373627: assert(!is_vthread_transition_disabler()) failed: no suspend allowed for vthread transition disablers

Reviewed-by: pchilanomate, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 121 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Dec 12, 2025
@openjdk
Copy link
Copy Markdown

openjdk bot commented Dec 12, 2025

@sspitsyn The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 12, 2025
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Dec 12, 2025

Webrevs

Copy link
Copy Markdown
Contributor

@pchilano pchilano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing this Serguei!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 15, 2025
Copy link
Copy Markdown
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@sspitsyn
Copy link
Copy Markdown
Contributor Author

Thank you for reviews, David and Patricio!

@sspitsyn
Copy link
Copy Markdown
Contributor Author

/integrate

@openjdk
Copy link
Copy Markdown

openjdk bot commented Dec 16, 2025

Going to push as commit 53ebcdb.
Since your change was applied there have been 126 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 16, 2025
@openjdk openjdk bot closed this Dec 16, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 16, 2025
@openjdk
Copy link
Copy Markdown

openjdk bot commented Dec 16, 2025

@sspitsyn Pushed as commit 53ebcdb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sspitsyn
Copy link
Copy Markdown
Contributor Author

/backport :jdk26

@openjdk
Copy link
Copy Markdown

openjdk bot commented Dec 17, 2025

@sspitsyn the backport was successfully created on the branch backport-sspitsyn-53ebcdbd-jdk26 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk26, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 53ebcdbd from the openjdk/jdk repository.

The commit being backported was authored by Serguei Spitsyn on 16 Dec 2025 and was reviewed by Patricio Chilano Mateo and David Holmes.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-sspitsyn-53ebcdbd-jdk26:backport-sspitsyn-53ebcdbd-jdk26
$ git checkout backport-sspitsyn-53ebcdbd-jdk26
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-sspitsyn-53ebcdbd-jdk26

⚠️ @sspitsyn You are not yet a collaborator in my fork openjdk-bots/jdk. An invite will be sent out and you need to accept it before you can proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants