8371503: RETAIN_IMAGE_AFTER_TEST do not work for some tests#28826
8371503: RETAIN_IMAGE_AFTER_TEST do not work for some tests#28826sendaoYan wants to merge 2 commits intoopenjdk:jdk26from
Conversation
|
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
@sendaoYan The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
Co-authored-by: Andrey Turbanov <turbanoff@gmail.com>
|
Change has been verified locally on linux-x64. This clean backport PR will make all the docker tests receive -Djdk.test.docker.retain.image property correctly. Verify command: |
|
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
Test-fix only, should we backport this fix to jdk26? |
|
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
I think we should close this PR now |
|
@sendaoYan This PR needs to re-target openjdk/jdk26u. This first needs to go to JDK 26 and later to older releases. |
Okey. |
Hi all,
This pull request contains a backport of commit 34f24131 from the openjdk/jdk repository.
The commit being backported was authored by SendaoYan on 15 Dec 2025 and was reviewed by Leonid Mesnik and David Holmes.
This clean backport PR will make all the docker tests receive -Djdk.test.docker.retain.image property correctly.
Thanks!
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28826/head:pull/28826$ git checkout pull/28826Update a local copy of the PR:
$ git checkout pull/28826$ git pull https://git.openjdk.org/jdk.git pull/28826/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28826View PR using the GUI difftool:
$ git pr show -t 28826Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28826.diff
Using Webrev
Link to Webrev Comment