8373807: test/jdk/java/net/httpclient/websocket/DummyWebSocketServer.java getURI() uses "localhost"

[dfuch]

The WebSockteTest was observed failing in timeout once, waiting for the completable future returned by WebSocketBuilder::build to complete. The suspicion is that it may have been caused by the request being misdirected due to the use of "localhost" in the URI.

This trivial fix ensures that the DumyWebSocketServer::getURI returns a URI with a literal IP address instead of relying on "localhost".

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8373807: test/jdk/java/net/httpclient/websocket/DummyWebSocketServer.java getURI() uses "localhost" (Bug - P4)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28864/head:pull/28864
$ git checkout pull/28864

Update a local copy of the PR:
$ git checkout pull/28864
$ git pull https://git.openjdk.org/jdk.git pull/28864/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28864

View PR using the GUI difftool:
$ git pr show -t 28864

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28864.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373807: test/jdk/java/net/httpclient/websocket/DummyWebSocketServer.java getURI() uses "localhost"

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 9a23f8a: 8373552: ExactConversionsSupport: bad JLS links in javadoc

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dfuch The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (7a5c42cf)

[jaikiran]

Hello Daniel, this looks OK to me. But given that we always use loopback address to bind the ServerSocketChannel in this test (line 333), can we just use loopback address here too?

[dfuch]

We could - I added a check to .isAnyLocalAddress() to make it generic and not make any assumption on the address the server would bind to.

[jaikiran]

Looks good to me.

[dfuch]

/integrate

[openjdk]

Going to push as commit f3a4856.
Since your change was applied there have been 6 commits pushed to the master branch:

• 4e05748: 8373716: Refactor further java/util tests from TestNG to JUnit
• 9862f8f: 8373513: C2: Move ProjNode::other_if_proj() to IfProjNode
• 39306d7: 8373800: Remove ScopedValueBindingsResolver
• ... and 3 more: https://git.openjdk.org/jdk/compare/fc76403b01c4e801f2a58810deeec2a6ebfa8458...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dfuch Pushed as commit f3a4856.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.