Skip to content

8373630: r18_tls should not be modified on Windows AArch64#28933

Closed
swesonga wants to merge 1 commit intoopenjdk:jdk26from
openjdk-bots:backport-swesonga-a0dd66f9-jdk26
Closed

8373630: r18_tls should not be modified on Windows AArch64#28933
swesonga wants to merge 1 commit intoopenjdk:jdk26from
openjdk-bots:backport-swesonga-a0dd66f9-jdk26

Conversation

@swesonga
Copy link
Member

@swesonga swesonga commented Dec 19, 2025

This pull request is a backport of commit a0dd66f9


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8373630: r18_tls should not be modified on Windows AArch64 (Bug - P1)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28933/head:pull/28933
$ git checkout pull/28933

Update a local copy of the PR:
$ git checkout pull/28933
$ git pull https://git.openjdk.org/jdk.git pull/28933/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28933

View PR using the GUI difftool:
$ git pr show -t 28933

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28933.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 19, 2025

👋 Welcome back swesonga! A progress list of the required criteria for merging this PR into jdk26 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 19, 2025

@swesonga This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373630: r18_tls should not be modified on Windows AArch64

Reviewed-by: aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk26 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@theRealAph) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport a0dd66f92d7f8400b9800847e36d036315628afb 8373630: r18_tls should not be modified on Windows AArch64 Dec 19, 2025
@openjdk
Copy link

openjdk bot commented Dec 19, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required hotspot-compiler hotspot-compiler-dev@openjdk.org labels Dec 19, 2025
@openjdk
Copy link

openjdk bot commented Dec 19, 2025

@swesonga The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 19, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 19, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 20, 2025
@swesonga
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 20, 2025
@openjdk
Copy link

openjdk bot commented Dec 20, 2025

@swesonga
Your change (at version a23ee36) is now ready to be sponsored by a Committer.

@theRealAph
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 20, 2025

Going to push as commit 1ec4ff5.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 20, 2025
@openjdk openjdk bot closed this Dec 20, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 20, 2025
@openjdk
Copy link

openjdk bot commented Dec 20, 2025

@theRealAph @swesonga Pushed as commit 1ec4ff5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants