Skip to content

8373110: jstack --mixed frames are broken on macOS after JDK-8371194#28958

Closed
YaSuenag wants to merge 1 commit intoopenjdk:jdk26from
openjdk-bots:backport-YaSuenag-b848ddf6-jdk26
Closed

8373110: jstack --mixed frames are broken on macOS after JDK-8371194#28958
YaSuenag wants to merge 1 commit intoopenjdk:jdk26from
openjdk-bots:backport-YaSuenag-b848ddf6-jdk26

Conversation

@YaSuenag
Copy link
Copy Markdown
Member

@YaSuenag YaSuenag commented Dec 23, 2025

Hi all,

This pull request contains a backport of commit b848ddf6 from the openjdk/jdk repository.

The commit being backported was authored by Yasumasa Suenaga on 18 Dec 2025 and was reviewed by Chris Plummer and Kevin Walls.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8373110: jstack --mixed frames are broken on macOS after JDK-8371194

Issue

  • JDK-8373110: jstack --mixed frames are broken on macOS after JDK-8371194 (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28958/head:pull/28958
$ git checkout pull/28958

Update a local copy of the PR:
$ git checkout pull/28958
$ git pull https://git.openjdk.org/jdk.git pull/28958/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28958

View PR using the GUI difftool:
$ git pr show -t 28958

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28958.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Dec 23, 2025

👋 Welcome back ysuenaga! A progress list of the required criteria for merging this PR into jdk26 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Dec 23, 2025

@YaSuenag This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373110: jstack --mixed frames are broken on macOS after JDK-8371194

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk26 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk26 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport b848ddf6d3bf4e76d409b03be7f36199dadb2c5f 8373110: jstack --mixed frames are broken on macOS after JDK-8371194 Dec 23, 2025
@openjdk
Copy link
Copy Markdown

openjdk bot commented Dec 23, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required serviceability serviceability-dev@openjdk.org labels Dec 23, 2025
@openjdk
Copy link
Copy Markdown

openjdk bot commented Dec 23, 2025

@YaSuenag The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 23, 2025
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Dec 23, 2025

Webrevs

Copy link
Copy Markdown
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 23, 2025
Copy link
Copy Markdown
Contributor

@plummercj plummercj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@YaSuenag
Copy link
Copy Markdown
Member Author

/integrate

@openjdk
Copy link
Copy Markdown

openjdk bot commented Dec 23, 2025

Going to push as commit cece06f.
Since your change was applied there has been 1 commit pushed to the jdk26 branch:

  • 8e0d736: 8373525: C2: assert(_base == Long) failed: Not a Long

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 23, 2025
@openjdk openjdk bot closed this Dec 23, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 23, 2025
@openjdk
Copy link
Copy Markdown

openjdk bot commented Dec 23, 2025

@YaSuenag Pushed as commit cece06f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@YaSuenag YaSuenag deleted the backport-YaSuenag-b848ddf6-jdk26 branch December 23, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants