8374351: RISC-V: Small refactoring for crypto macro-assembler routines#28988
8374351: RISC-V: Small refactoring for crypto macro-assembler routines#28988Anjian-Wen wants to merge 2 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back wenanjian! A progress list of the required criteria for merging this PR into |
|
@Anjian-Wen This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
@Anjian-Wen The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
/issue JDK-8374351 |
|
@Anjian-Wen The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated. |
Webrevs
|
RealFYang
left a comment
There was a problem hiding this comment.
Seems fine. One minor comment.
| VectorRegister vtmp3 = v3; | ||
|
|
||
| const unsigned int BLOCK_SIZE = 16; | ||
| ghash_loop(subkeyH, state, data, blocks, vtmp1, vtmp2, vtmp3); |
There was a problem hiding this comment.
state is the first param for generate_ghash_processBlocks. Can we simply swap the first two params to keep that order?
There was a problem hiding this comment.
sure, Thanks for the advice
|
@RealFYang @feilongjiang Thanks for the review! |
|
/integrate |
|
Going to push as commit 5e685f6.
Your commit was automatically rebased without conflicts. |
|
@Anjian-Wen Pushed as commit 5e685f6. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This patch is mainly for readability and subsequent GCM call requirements.
generate_prefixProgress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28988/head:pull/28988$ git checkout pull/28988Update a local copy of the PR:
$ git checkout pull/28988$ git pull https://git.openjdk.org/jdk.git pull/28988/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28988View PR using the GUI difftool:
$ git pr show -t 28988Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28988.diff
Using Webrev
Link to Webrev Comment