Skip to content

8374351: RISC-V: Small refactoring for crypto macro-assembler routines#28988

Closed
Anjian-Wen wants to merge 2 commits intoopenjdk:masterfrom
Anjian-Wen:riscv_ghash_modify
Closed

8374351: RISC-V: Small refactoring for crypto macro-assembler routines#28988
Anjian-Wen wants to merge 2 commits intoopenjdk:masterfrom
Anjian-Wen:riscv_ghash_modify

Conversation

@Anjian-Wen
Copy link
Contributor

@Anjian-Wen Anjian-Wen commented Dec 25, 2025

This patch is mainly for readability and subsequent GCM call requirements.

  1. Extract the ghash function to facilitate subsequent calls during the implementation of aes-gcm
  2. Unify the prefixes of function names for aes intrinsic-related functions. Only use generate prefix for the main intrinsic function, delete the other functions generate_ prefix

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374351: RISC-V: Small refactoring for crypto macro-assembler routines (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28988/head:pull/28988
$ git checkout pull/28988

Update a local copy of the PR:
$ git checkout pull/28988
$ git pull https://git.openjdk.org/jdk.git pull/28988/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28988

View PR using the GUI difftool:
$ git pr show -t 28988

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28988.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 25, 2025

👋 Welcome back wenanjian! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 25, 2025

@Anjian-Wen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374351: RISC-V: Small refactoring for crypto macro-assembler routines

Reviewed-by: fyang, fjiang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 3e6170c: 8374354: Update copyright year to 2025 for jdk.javadoc in files where it was missed
  • 534c33d: 8374323: Update copyright year to 2025 for the build system in files where it was missed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Dec 25, 2025
@openjdk
Copy link

openjdk bot commented Dec 25, 2025

@Anjian-Wen The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@Anjian-Wen
Copy link
Contributor Author

/issue JDK-8374351

@openjdk openjdk bot changed the title RISC-V: extraction and reconstruction of the ghash loop function 8374351: RISC-V: extraction and reconstruction of the ghash loop function Dec 25, 2025
@openjdk
Copy link

openjdk bot commented Dec 25, 2025

@Anjian-Wen The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

@Anjian-Wen Anjian-Wen changed the title 8374351: RISC-V: extraction and reconstruction of the ghash loop function 8374351: RISC-V: Small refactoring for crypto macro-assembler routines Dec 26, 2025
@Anjian-Wen Anjian-Wen marked this pull request as ready for review December 26, 2025 02:37
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 26, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 26, 2025

Webrevs

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. One minor comment.

VectorRegister vtmp3 = v3;

const unsigned int BLOCK_SIZE = 16;
ghash_loop(subkeyH, state, data, blocks, vtmp1, vtmp2, vtmp3);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

state is the first param for generate_ghash_processBlocks. Can we simply swap the first two params to keep that order?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, Thanks for the advice

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 26, 2025
Copy link
Member

@feilongjiang feilongjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Anjian-Wen
Copy link
Contributor Author

@RealFYang @feilongjiang Thanks for the review!

@Anjian-Wen
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 28, 2025

Going to push as commit 5e685f6.
Since your change was applied there have been 8 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 28, 2025
@openjdk openjdk bot closed this Dec 28, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 28, 2025
@openjdk
Copy link

openjdk bot commented Dec 28, 2025

@Anjian-Wen Pushed as commit 5e685f6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants