Skip to content

8374444: Fix simple -Wzero-as-null-pointer-constant warnings#29014

Closed
kimbarrett wants to merge 2 commits intoopenjdk:masterfrom
kimbarrett:simple-zero-as-null-pointer-warnings
Closed

8374444: Fix simple -Wzero-as-null-pointer-constant warnings#29014
kimbarrett wants to merge 2 commits intoopenjdk:masterfrom
kimbarrett:simple-zero-as-null-pointer-warnings

Conversation

@kimbarrett
Copy link

@kimbarrett kimbarrett commented Jan 1, 2026

Please review this trivial change to fix several recent changes that trigger
-Wzero-as-null-pointer-constant warnings when that warning is enabled.

Testing: mach5 tier1


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374444: Fix simple -Wzero-as-null-pointer-constant warnings (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29014/head:pull/29014
$ git checkout pull/29014

Update a local copy of the PR:
$ git checkout pull/29014
$ git pull https://git.openjdk.org/jdk.git pull/29014/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29014

View PR using the GUI difftool:
$ git pr show -t 29014

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29014.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 1, 2026

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 1, 2026

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374444: Fix simple -Wzero-as-null-pointer-constant warnings

Reviewed-by: aboldtch

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jan 1, 2026
@openjdk
Copy link

openjdk bot commented Jan 1, 2026

@kimbarrett The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 1, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 1, 2026

Webrevs

Copy link
Member

@xmas92 xmas92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Trivial.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 2, 2026
@kimbarrett
Copy link
Author

Thanks for review @xmas92

@kimbarrett
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 2, 2026

Going to push as commit efb79dc.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 05d2f7f: 8373847: Test javax/swing/JMenuItem/MenuItemTest/bug6197830.java failed because The test case automatically fails when clicking any items in the “Nothing” menu in all four windows (Left-to-right)-Menu Item Test and (Right-to-left)-Menu Item Test
  • 2ea3c00: 4337898: Serializing DefaultTableCellRenderer changes colors
  • 65af6bc: 8374371: Failed assertion in G1HeapRegion gtest

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 2, 2026
@openjdk openjdk bot closed this Jan 2, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 2, 2026
@openjdk
Copy link

openjdk bot commented Jan 2, 2026

@kimbarrett Pushed as commit efb79dc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kimbarrett kimbarrett deleted the simple-zero-as-null-pointer-warnings branch January 2, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants