8374525: RISC-V: Several masked float16 vector operations are not supported#29035
8374525: RISC-V: Several masked float16 vector operations are not supported#29035DingliZhang wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into |
|
@DingliZhang This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 103 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@DingliZhang The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
Thanks all for the review! |
|
Going to push as commit df5b49e.
Your commit was automatically rebased without conflicts. |
|
@DingliZhang Pushed as commit df5b49e. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi,
Can you help to review this patch? Thanks!
Currently, the masked versions of the following 8 Float16 operations are not supported.
But we return true in
Matcher::match_rule_supported_vector_maskedfor these operationson RISC-V platforms with Zvfh. We need to explicitly disable them on this CPU platform
to make it clear.
When the support for Float16 vector classes is added in VectorAPI and the masked
Float16 IR can be generated, these masked operations will be enabled and relevant
backend support added.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29035/head:pull/29035$ git checkout pull/29035Update a local copy of the PR:
$ git checkout pull/29035$ git pull https://git.openjdk.org/jdk.git pull/29035/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 29035View PR using the GUI difftool:
$ git pr show -t 29035Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29035.diff
Using Webrev
Link to Webrev Comment