Skip to content

8374525: RISC-V: Several masked float16 vector operations are not supported#29035

Closed
DingliZhang wants to merge 1 commit intoopenjdk:masterfrom
DingliZhang:JDK-8374525
Closed

8374525: RISC-V: Several masked float16 vector operations are not supported#29035
DingliZhang wants to merge 1 commit intoopenjdk:masterfrom
DingliZhang:JDK-8374525

Conversation

@DingliZhang
Copy link
Member

@DingliZhang DingliZhang commented Jan 5, 2026

Hi,
Can you help to review this patch? Thanks!

Currently, the masked versions of the following 8 Float16 operations are not supported.
But we return true in Matcher::match_rule_supported_vector_masked for these operations
on RISC-V platforms with Zvfh. We need to explicitly disable them on this CPU platform
to make it clear.

 Op_AddVHF:
 Op_SubVHF:
 Op_MulVHF:
 Op_DivVHF:
 Op_MaxVHF:
 Op_MinVHF:
 Op_SqrtVHF:
 Op_FmaVHF:

When the support for Float16 vector classes is added in VectorAPI and the masked
Float16 IR can be generated, these masked operations will be enabled and relevant
backend support added.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374525: RISC-V: Several masked float16 vector operations are not supported (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29035/head:pull/29035
$ git checkout pull/29035

Update a local copy of the PR:
$ git checkout pull/29035
$ git pull https://git.openjdk.org/jdk.git pull/29035/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29035

View PR using the GUI difftool:
$ git pr show -t 29035

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29035.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 5, 2026

👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 5, 2026

@DingliZhang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374525: RISC-V: Several masked float16 vector operations are not supported

Reviewed-by: fjiang, fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 103 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jan 5, 2026
@openjdk
Copy link

openjdk bot commented Jan 5, 2026

@DingliZhang The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 5, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 5, 2026

Webrevs

Copy link
Member

@feilongjiang feilongjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 5, 2026
@DingliZhang
Copy link
Member Author

Thanks all for the review!
/integrate

@openjdk
Copy link

openjdk bot commented Jan 6, 2026

Going to push as commit df5b49e.
Since your change was applied there have been 117 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 6, 2026
@openjdk openjdk bot closed this Jan 6, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 6, 2026
@openjdk
Copy link

openjdk bot commented Jan 6, 2026

@DingliZhang Pushed as commit df5b49e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants