Skip to content

8374544: Add SleepyCat diagnostics for all platforms#29047

Closed
RogerRiggs wants to merge 2 commits intoopenjdk:masterfrom
RogerRiggs:8374544-sleepcat-diag
Closed

8374544: Add SleepyCat diagnostics for all platforms#29047
RogerRiggs wants to merge 2 commits intoopenjdk:masterfrom
RogerRiggs:8374544-sleepcat-diag

Conversation

@RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented Jan 5, 2026

To aid diagnosis of these intermittent failures, add diagnostic information to the test failures.
On timeout, show ps and lsof commands for processes under test Add TEST.properties to increase jtreg maxOutputSize=6000000


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374544: Add SleepyCat diagnostics for all platforms (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29047/head:pull/29047
$ git checkout pull/29047

Update a local copy of the PR:
$ git checkout pull/29047
$ git pull https://git.openjdk.org/jdk.git pull/29047/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29047

View PR using the GUI difftool:
$ git pr show -t 29047

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29047.diff

Using Webrev

Link to Webrev Comment

On timeout, show ps and lsof commands for processes under test
Add TEST.properties to increase jtreg maxOutputSize=6000000
@RogerRiggs RogerRiggs marked this pull request as ready for review January 5, 2026 20:14
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 5, 2026

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 5, 2026

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374544: Add SleepyCat diagnostics for all platforms

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8374544: Add SleepyCat diagnostics for all platforms 8374544: Add SleepyCat diagnostics for all platforms Jan 5, 2026
@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 5, 2026
@openjdk
Copy link

openjdk bot commented Jan 5, 2026

@RogerRiggs The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 5, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 5, 2026

Webrevs

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Roger, the changes look OK to me. The copyright year on the test file will need an update.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 6, 2026
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jan 6, 2026
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 6, 2026
@RogerRiggs
Copy link
Contributor Author

/integrate

Thanks for the reviews.

@openjdk
Copy link

openjdk bot commented Jan 6, 2026

Going to push as commit f1e0e0c.
Since your change was applied there have been 19 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 6, 2026
@openjdk openjdk bot closed this Jan 6, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 6, 2026
@openjdk
Copy link

openjdk bot commented Jan 6, 2026

@RogerRiggs Pushed as commit f1e0e0c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants