8374506: Incorrect positioning of arrow icon in parent JMenu in Windows L&F

[prsadhuk]

Arrow icon of JMenuItem in JMenu which is used to invoke the submenu overlaps with the menutext if the text is long.

Fix is made to add a gap for arrow icon rect too similar to menu text and accelerator rects

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8374506: Incorrect positioning of arrow icon in parent JMenu in Windows L&F (Bug - P3)

Reviewers

• Alexey Ivanov (@aivanov-jdk - Reviewer)
• Alexander Zuev (@azuev-java - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29375/head:pull/29375
$ git checkout pull/29375

Update a local copy of the PR:
$ git checkout pull/29375
$ git pull https://git.openjdk.org/jdk.git pull/29375/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29375

View PR using the GUI difftool:
$ git pr show -t 29375

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29375.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374506: Incorrect positioning of arrow icon in parent JMenu in Windows L&F

Reviewed-by: aivanov, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 97 new commits pushed to the master branch:

• 847b516: 8373018: Update OpenSSL version to 3.5.4
• a54ff1b: 8376523: Move interned strings into AOT heap roots array
• 7c6c34e: 8370502: C2: segfault while adding node to IGVN worklist
• ... and 94 more: https://git.openjdk.org/jdk/compare/0f087a7fef2d3979badefde02a1e85351379f18c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@prsadhuk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (2ec91ff7)

[prrace]

@TejeshR13 @DamonGuy @azuev-java please review

[aivanov-jdk]

I'm not completely against this as an interim fix…
Yet the submenu arrow now is nearly at the very edge of the menu — there has to be a margin. When the submenu opens, it now covers the arrow, but it shouldn't. At least this is how it looks in native Win32 applications.

This fix is yet another patch to fit more information into the same amount of space.

The underlying problem remains unaddressed. In the fix for JDK-8348760 in #23324, you added another column into Windows L&F menu layout, but you didn't increase the width of the menu to accommodate for the new column. Instead, you're trying to tweak coordinates of each element in the menu layout to fit more information into the same space.

I keep saying since that initial code review for #23324, for example here, and I repeat it here:

The popup menu has to become wider if both check marks / bullets and icons are rendered at the same time.

Unless you make the menu wider to accommodate the newly added column, the menu looks crammed with inconsistent margins between elements.

[azuev-java]

With the fix it is better than without the fix - that is for sure, but the overall layout looks strange and majority of the arrow icon is being hidden behind the submenu's popup which is wrong. I am approving it as a stopgap solution but the overall we might want to re-visit how we calculate layouts of menu items to make it look more like a OS native menus.

[aivanov-jdk]

I agree with @azuev-java, it looks better this way.

[prsadhuk]

/integrate

[openjdk]

Going to push as commit 9a10cce.
Since your change was applied there have been 101 commits pushed to the master branch:

• 379dcb0: 8365313: GTK LaF does not respect system color scheme with Gnome
• 175bbb1: 8375569: Store Java mirrors in AOT configuration file
• 9470aa3: 8375011: OldJTable.java - NullPointerException when columnData is null
• ... and 98 more: https://git.openjdk.org/jdk/compare/0f087a7fef2d3979badefde02a1e85351379f18c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prsadhuk Pushed as commit 9a10cce.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[aivanov-jdk]

The popup menu has to become wider if both check marks / bullets and icons are rendered at the same time.

I am approving it as a stopgap solution but the overall we might want to re-visit how we calculate layouts of menu items to make it look more like a OS native menus.

I've now submitted JDK-8376828: Improve JMenuItem layout in Windows L&F.