8378149: [s390] Non-C2 / minimal JVM crashes in the build#29777
8378149: [s390] Non-C2 / minimal JVM crashes in the build#29777offamitkumar wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into |
|
@offamitkumar This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@offamitkumar The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
I think what you tested sounds sufficient. |
|
Thanks for approval :) , failure on windows-x64 is unrelated to this PR's changes. /integrate |
|
Going to push as commit 7d2b6ed.
Your commit was automatically rebased without conflicts. |
|
@offamitkumar Pushed as commit 7d2b6ed. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This build failure will only occur if continuations support is enabled. In my continuation port when I did the build it failed with the same error which we have seen in past on ppc platform.
Testing: Build fixed with the current code change and on headstream I didn't see any new issue appearing for s390 with tier1 testcase run.
CC: @MBaesken @TheRealMDoerr will it be possible if you take a look at this PR as changes are similar to #23794 . Let me know if there is requirement to ran other test with any different vm.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29777/head:pull/29777$ git checkout pull/29777Update a local copy of the PR:
$ git checkout pull/29777$ git pull https://git.openjdk.org/jdk.git pull/29777/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 29777View PR using the GUI difftool:
$ git pr show -t 29777Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29777.diff
Using Webrev
Link to Webrev Comment