8378398: Modernize test/jdk/java/net/URLClassLoader/HttpTest.java

[eirbjo]

Please review this PR which modernizes test/jdk/java/net/URLClassLoader/HttpTest.java, a test verifying HTTP requests made by a URLClassLoader with HTTP search paths.

The test is updated to replace a custom HttpServer class with one using com.sun.net.httpserver. Instead of simply counting GET and HEAD requests, the test now captures each request's method and URI in a log, which allows more precise asserts on the expected request patterns.

The test is updated to use JUnit 5.

For good measure, some negative test methods are added, verifying expected HTTP requests when one of the HTTP paths returns a 404 response.

Test-only enhancement, noreg-self

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8378398: Modernize test/jdk/java/net/URLClassLoader/HttpTest.java (Enhancement - P4)

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29864/head:pull/29864
$ git checkout pull/29864

Update a local copy of the PR:
$ git checkout pull/29864
$ git pull https://git.openjdk.org/jdk.git pull/29864/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29864

View PR using the GUI difftool:
$ git pr show -t 29864

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29864.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back eirbjo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@eirbjo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8378398: Modernize test/jdk/java/net/URLClassLoader/HttpTest.java

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 132 new commits pushed to the master branch:

• 82ff025: 8374910: Use of containsTypeEquivalent in array type equality test seems bogus
• b13a291: 8378268: Thread.join can wait on Thread, allows joinNanos to be removed
• 173153e: 8376403: Avoid loading ArrayDeque in java.util.zip.ZipFile
• ... and 129 more: https://git.openjdk.org/jdk/compare/d02ac57e8469ac77cc4f53de77107a278ac5f346...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@eirbjo The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 04: Full - Incremental (22048aea)
• 03: Full - Incremental (b6a47357)
• 02: Full - Incremental (68c02396)
• 01: Full - Incremental (5f00ae9a)
• 00: Full (18758937)

[dfuch]

Hi Eirik, overall good cleanup!

[dfuch]

Since the test is now using jdk.httpserver we should add
@modules jdk.httpserver

Please give us some time to verify that the new test is stable in the CI.

[eirbjo]

Since the test is now using jdk.httpserver we should add @modules jdk.httpserver

Thanks, fixed.

Please give us some time to verify that the new test is stable in the CI.

Based on the discussion in https://mail.openjdk.org/pipermail/net-dev/2026-February/030179.html, I opted to add some more redirect tests (including failing redirect targets) and to add note comments / notes explaining the somewhat suboptimal, but long-standing redirect behavior.

Could you take a look at those and re-spin any testing?

[dfuch]

LGTM. Thanks for the cleanup.

[eirbjo]

Thanks Daniel for the review and help in CI testing!

/integrate

[openjdk]

Going to push as commit 3b8abd4.
Since your change was applied there have been 132 commits pushed to the master branch:

• 82ff025: 8374910: Use of containsTypeEquivalent in array type equality test seems bogus
• b13a291: 8378268: Thread.join can wait on Thread, allows joinNanos to be removed
• 173153e: 8376403: Avoid loading ArrayDeque in java.util.zip.ZipFile
• ... and 129 more: https://git.openjdk.org/jdk/compare/d02ac57e8469ac77cc4f53de77107a278ac5f346...master

Your commit was automatically rebased without conflicts.

[openjdk]

@eirbjo Pushed as commit 3b8abd4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.