Skip to content

Upstream some redundant diffs fixed in Valhalla#29944

Draft
liach wants to merge 1 commit intoopenjdk:masterfrom
liachmodded:fix/valhalla-cleans
Draft

Upstream some redundant diffs fixed in Valhalla#29944
liach wants to merge 1 commit intoopenjdk:masterfrom
liachmodded:fix/valhalla-cleans

Conversation

@liach
Copy link
Member

@liach liach commented Feb 26, 2026

In the lworld diff review for java.base, some diff are identified problems with mainline and best upstreamed to mainline than reverted in lworld.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29944/head:pull/29944
$ git checkout pull/29944

Update a local copy of the PR:
$ git checkout pull/29944
$ git pull https://git.openjdk.org/jdk.git pull/29944/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29944

View PR using the GUI difftool:
$ git pr show -t 29944

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29944.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 26, 2026

👋 Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 26, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added javadoc javadoc-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Feb 26, 2026
@openjdk
Copy link

openjdk bot commented Feb 26, 2026

@liach The following labels will be automatically applied to this pull request:

  • core-libs
  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@RogerRiggs
Copy link
Contributor

Nice cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org javadoc javadoc-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants