8379114: HttpServer path prefix matching incorrectly matches paths that are not slash-prefixed

[vy]

JDK-8272758 (#29264) incorrectly added the if (contextPath == '/') { return true; } fast path to the HttpServer context matcher. As a result, GET foo started matching context /, where it should not. Fix this.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8379114: HttpServer path prefix matching incorrectly matches paths that are not slash-prefixed (Bug - P3)

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30044/head:pull/30044
$ git checkout pull/30044

Update a local copy of the PR:
$ git checkout pull/30044
$ git pull https://git.openjdk.org/jdk.git pull/30044/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30044

View PR using the GUI difftool:
$ git pr show -t 30044

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30044.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vyazici! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8379114: HttpServer path prefix matching incorrectly matches paths that are not slash-prefixed

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• eb50630: 8379013: Remove some unused code in generateOopMap.cpp
• 7c8f66c: 8379041: Crash in ResolvedFieldEntry::assert_is_valid(): invalid put bytecode 0
• 12af936: 8377986: C2: New method to add specific users to the worklist
• ... and 6 more: https://git.openjdk.org/jdk/compare/f26b379b97301aca49dda9cb5dfe9a5472af7140...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@vy The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5a31abaf)

[vy]

Tier 1-2 is clear on 5a31aba.

/integrate

[openjdk]

Going to push as commit 0668dab.
Since your change was applied there have been 27 commits pushed to the master branch:

• dfea6eb: 8378598: Refactor tests under test/jdk/java/net/httpclient/websocket from TestNG to JUnit
• a0c0a36: 8378600: Refactor tests under test/jdk/java/net/httpclient/http2 from TestNG to JUnit
• fc77e3e: 8378599: Refactor tests under test/jdk/java/net/httpclient/whitebox from TestNG to JUnit
• ... and 24 more: https://git.openjdk.org/jdk/compare/f26b379b97301aca49dda9cb5dfe9a5472af7140...master

Your commit was automatically rebased without conflicts.

[openjdk]

@vy Pushed as commit 0668dab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.