8380764: Vector classes should have @ValueBased

[YaSuenag]

According to Javadoc of jdk.incubator.vector.Vector, vector classes are declared as value based class. However all vector classes (e.g. IntVector256) do not have @jdk.internal.ValueBased, so DiagnoseSyncOnValueBasedClasses does not affect if vector object are used as a monitor.

This PR fixes all of final classes of vector, but most of files were generated by gen-src.sh. Essense of this PR is a chenge for X-VectorBits.java.template.
After this change, we can see following logs if -XX:DiagnoseSyncOnValueBasedClasses is set and vector class is used as monitor object.

$ java --add-modules jdk.incubator.vector -XX:DiagnoseSyncOnValueBasedClasses=2  ValueBaseLock
WARNING: Using incubator modules: jdk.incubator.vector
[0.453s][info][valuebasedclasses] Synchronizing on object 0x00000000823b1258 of klass jdk.incubator.vector.IntVector256
[0.453s][info][valuebasedclasses]       at ValueBaseLock.run(ValueBaseLock.java:9)
[0.453s][info][valuebasedclasses]       - locked <0x00000000823b1258> (a jdk.incubator.vector.IntVector256)
[0.453s][info][valuebasedclasses]       at java.lang.Thread.runWith(java.base@27-internal/Thread.java:1540)
[0.453s][info][valuebasedclasses]       at java.lang.Thread.run(java.base@27-internal/Thread.java:1527)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8380764: Vector classes should have @ValueBased (Bug - P4)

Reviewers

• Chen Liang (@liach - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30392/head:pull/30392
$ git checkout pull/30392

Update a local copy of the PR:
$ git checkout pull/30392
$ git pull https://git.openjdk.org/jdk.git pull/30392/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30392

View PR using the GUI difftool:
$ git pr show -t 30392

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30392.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ysuenaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@YaSuenag This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8380764: Vector classes should have @ValueBased

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

• 46e6b26: 8372646: C2: Stress Counted Loop creation
• 3737cad: 8370947: Mitigate Neoverse-N1 erratum 1542419 negative impact on GCs and JIT performance
• 7d24a09: 8380824: java/net/DatagramSocket/SendReceiveMaxSize.java could also test the loopback interface
• ... and 21 more: https://git.openjdk.org/jdk/compare/cc29010ae29c65964b44e9f472ad0c1d9f848f0a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@YaSuenag The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (55ae0523)
• 00: Full (fedaf339)

[liach]

Re-@ValueBased:

1. We need such an excerpt in every immediately annotated classes:

 * <p>This is a <a href="{@docRoot}/java.base/java/lang/doc-files/ValueBased.html">value-based</a>
 * class; programmers should treat instances that are
 * {@linkplain #equals(Object) equal} as interchangeable and should not
 * use instances for synchronization, or unpredictable behavior may
 * occur. For example, in a future release, synchronization may fail.

2. VectorMask and VectorShuffle should be marked so too.

[YaSuenag]

VectorMask and VectorShuffle should be marked so too.

Good catch! I added @ValueBased to all of VectorMask and VectorShuffle implementations, and re-run gen-src.sh.

We need such an excerpt in every immediately annotated classes:

Indeed.
AFAICS following classes (or their final implementations) should have @ValueBased. Most of classes are FFM related classes, but I haven't yet find out what should be treated.

java.base/share/classes/java/lang/foreign/AddressLayout.java
java.base/share/classes/java/lang/foreign/FunctionDescriptor.java
java.base/share/classes/java/lang/foreign/GroupLayout.java
java.base/share/classes/java/lang/foreign/MemoryLayout.java
java.base/share/classes/java/lang/foreign/PaddingLayout.java
java.base/share/classes/java/lang/foreign/SequenceLayout.java
java.base/share/classes/java/lang/foreign/StructLayout.java
java.base/share/classes/java/lang/foreign/UnionLayout.java
java.base/share/classes/java/lang/foreign/ValueLayout.java
java.base/share/classes/java/lang/foreign/MemorySegment.java
java.base/share/classes/java/lang/foreign/Linker.java
java.base/share/classes/java/util/HexFormat.java
java.base/share/classes/jdk/internal/foreign/FunctionDescriptorImpl.java
java.base/share/classes/jdk/internal/foreign/layout/ValueLayouts.java

[liach]

Looks reasonable. For ffm layouts and hex format, please create one jbs issue for each VBC addition.

[YaSuenag]

@liach Thanks for your review!
I filed JDK-8380955 ( #30443 ) for FFM, and JDK-8380956 ( #30444 ) for HexFormat. I hope they could have the review.

/integrate

[openjdk]

Going to push as commit 960161d.
Since your change was applied there have been 37 commits pushed to the master branch:

• 69deec2: 8378985: serviceability/sa/TestJhsdbJstackMixedWithXComp.java failed if sender frame is return barrier of Continuation
• ceb109f: 8380081: jpackage: Incorrect descriptions of win-specific options
• a55656d: 8380789: RISC-V: TestOpaqueConstantBoolNodes.java fails when running without RVV
• ... and 34 more: https://git.openjdk.org/jdk/compare/cc29010ae29c65964b44e9f472ad0c1d9f848f0a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@YaSuenag Pushed as commit 960161d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.