8382201: Transparent Window is Opaque w/o Volatile Buffering by mickleness · Pull Request #30737 · openjdk/jdk

mickleness · 2026-04-15T06:14:24Z

If swing.volatileImageBufferEnabled is turned off: MTLGraphicsConfig and CGLGraphicsConfig should use a translucent image for double buffering.

This test is marked as mac-only, but it should be harmless to turn that flag off if anyone wants to test other platforms. In previous threads we established that this is a Mac-only issue: #23430 (comment)

I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

JDK-8382201: Transparent Window is Opaque w/o Volatile Buffering (Bug - P3)

Reviewers

Phil Race (@prrace - Reviewer)
Jayathirth D V (@jayathirthrao - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30737/head:pull/30737
$ git checkout pull/30737

Update a local copy of the PR:
$ git checkout pull/30737
$ git pull https://git.openjdk.org/jdk.git pull/30737/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30737

View PR using the GUI difftool:
$ git pr show -t 30737

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30737.diff

Using Webrev

Link to Webrev Comment

Also RepaintManager may let windows share the same buffer. In this test's case: the white background (in an opaque Frame) set up a large buffer, and the smaller translucent dialog needs to recreate a buffer to provide translucency.

bridgekeeper · 2026-04-15T06:16:22Z

👋 Welcome back jwood! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2026-04-15T06:16:27Z

@mickleness This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8382201: Transparent Window is Opaque w/o Volatile Buffering

Reviewed-by: prr, jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

4507ab8: 8379973: Provide means to customize localized patterns in DateTimeFormatter/Builder
f99a62a: 8381380: Test host wildcard matching as part of a TLS validation of the server's identity
87fdbc5: 8372817: Remove test/jdk/sun/security/rsa silent skips
... and 33 more: https://git.openjdk.org/jdk/compare/d037d6296893dbea9863b2c12b847361c59e4ba9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace, @jayathirthrao) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2026-04-15T06:17:31Z

@mickleness The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2026-04-15T06:22:08Z

Webrevs

openjdk · 2026-04-16T18:54:31Z

The total number of required reviews for this PR has been set to 2 based on the presence of this label: client. This can be overridden with the /reviewers command.

mickleness · 2026-04-17T03:32:56Z

Converting to draft; I want to resolve #30783 first.

Also simplifying unit test so it doesn't require a white background Frame. The opacity issue is important, but it can be represented as a separate ticket. (I'm trying to keep PRs as simple as possible to speed up/simplify code review.)

I must have gotten my tickets mixed up when I removed these properties. We DO want to toggle opengl (so we test both MTL and CGL), and we want volatile images permanently off for this test.

prrace · 2026-04-21T21:14:27Z

I tested OpenGL and Metal with your test as well as SwingSet and J2Demo and it looks good.
I will however also submit a test job to run all our automated tests.

prrace · 2026-04-22T20:32:32Z

+/*
+ * @test
+ * @bug     8382201
+ * @summary This tests window translucency when


The test needs
@key headful

OK, this is updated

prrace · 2026-04-22T20:33:21Z

+    private void run() {
+        try {
+            SwingUtilities.invokeAndWait(() -> {
+                JDialog translucentDialog = createDialog();


This dialog is never disposed, so you are relying on jtreg shutting the test down to cause the test to terminate.

OK, this is updated

prrace · 2026-04-22T20:33:43Z

+ * @summary This tests window translucency when
+ *          `swing.volatileImageBufferEnabled=false`
+ * @requires os.family == "mac"
+ * @library /java/awt/regtesthelpers


I don't see any use of regtesthelpers here

OK, this is updated

This is in response to: openjdk#30737 (comment)

prrace · 2026-04-22T21:26:41Z

+/*
+ * @test
+ * @bug     8382201
+` * @key headful


There's an errant "`" at the beginning of that line

Ah, sorry. This is updated

This is in response to: https://github.com/openjdk/jdk/pull/30737/changes#r3127004349

jayathirthrao

Change looks good to me, except comment about copyright year.
Verified test behaviour also on my mac.

jayathirthrao · 2026-04-27T10:07:17Z

@@ -0,0 +1,183 @@
+/*
+ * Copyright (c) 1999, 2026, Oracle and/or its affiliates. All rights reserved.


This is a new test, it should have only starting year 2026

OK, this is updated

This is in response to: openjdk#30737 (review)

mickleness · 2026-04-30T04:57:11Z

/integrate

openjdk · 2026-04-30T04:59:08Z

@mickleness This pull request has not yet been marked as ready for integration.

mickleness · 2026-05-01T19:44:33Z

/integrate

openjdk · 2026-05-01T19:45:09Z

@mickleness
Your change (at version 854c914) is now ready to be sponsored by a Committer.

prrace · 2026-05-04T22:03:42Z

/integrate

prrace · 2026-05-04T22:03:53Z

/sponsor

openjdk · 2026-05-04T22:43:32Z

@prrace Only the author (@mickleness) is allowed to issue the integrate command. As this pull request is ready to be sponsored, and you are an eligible sponsor, did you mean to issue the /sponsor command?

openjdk · 2026-05-04T22:53:41Z

Going to push as commit ebb3d68.
Since your change was applied there have been 57 commits pushed to the master branch:

c2074e4: 8383824: TestCopyFiles.java fails after JDK-8347112
6e5e4f6: 8377938: VoiceOver Uses Mouse to Activate JButtons in German
06e6539: 8374839: Improve jpackage information messages
... and 54 more: https://git.openjdk.org/jdk/compare/d037d6296893dbea9863b2c12b847361c59e4ba9...master

Your commit was automatically rebased without conflicts.

openjdk · 2026-05-04T22:54:51Z

@prrace @mickleness Pushed as commit ebb3d68.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk Bot added the client client-libs-dev@openjdk.org label Apr 15, 2026

openjdk Bot added the rfr Pull request is ready for review label Apr 15, 2026

mickleness marked this pull request as draft April 17, 2026 03:32

openjdk Bot removed the rfr Pull request is ready for review label Apr 17, 2026

mickleness added 4 commits April 20, 2026 15:51

Merge branch 'master' into 8382201

68b3fa6

8382201: removing isWrongOpacity

7f7f83c

Also simplifying unit test so it doesn't require a white background Frame. The opacity issue is important, but it can be represented as a separate ticket. (I'm trying to keep PRs as simple as possible to speed up/simplify code review.)

8382201: resetting RepaintManager so diff is clean

74482ee

8382201: adding extra {}'s for code review

292d07d

mickleness marked this pull request as ready for review April 20, 2026 23:54

openjdk Bot added the rfr Pull request is ready for review label Apr 20, 2026

8382201: reinstating correct properties

0cf8468

I must have gotten my tickets mixed up when I removed these properties. We DO want to toggle opengl (so we test both MTL and CGL), and we want volatile images permanently off for this test.

prrace reviewed Apr 22, 2026

View reviewed changes

mickleness added 3 commits April 22, 2026 16:59

8382201: adding @key headful

54c5234

This is in response to: openjdk#30737 (comment)

8382201: disposing dialog

4a56371

This is in response to: openjdk#30737 (comment)

8382201: removing regtesthelpers

5ec80c2

This is in response to: openjdk#30737 (comment)

prrace reviewed Apr 22, 2026

View reviewed changes

8382201: fixing @key headful

2b64776

This is in response to: https://github.com/openjdk/jdk/pull/30737/changes#r3127004349

prrace approved these changes Apr 22, 2026

View reviewed changes

jayathirthrao reviewed Apr 27, 2026

View reviewed changes

mickleness added 2 commits April 27, 2026 10:04

8382201: updating copyright year

2b62518

This is in response to: openjdk#30737 (review)

Merge remote-tracking branch 'origin/master' into 8382201

854c914

jayathirthrao approved these changes Apr 30, 2026

View reviewed changes

mickleness requested a review from prrace April 30, 2026 16:49

prrace approved these changes May 1, 2026

View reviewed changes

openjdk Bot added the ready Pull request is ready to be integrated label May 1, 2026

openjdk Bot added the sponsor Pull request is ready to be sponsored label May 1, 2026

openjdk Bot added the integrated Pull request has been integrated label May 4, 2026

openjdk Bot closed this May 4, 2026

openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 4, 2026

		@@ -0,0 +1,183 @@
		/*
		* Copyright (c) 1999, 2026, Oracle and/or its affiliates. All rights reserved.

Conversation

mickleness commented Apr 15, 2026 • edited by openjdk Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper Bot commented Apr 15, 2026

Uh oh!

openjdk Bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk Bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mlbridge Bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

openjdk Bot commented Apr 16, 2026

Uh oh!

mickleness commented Apr 17, 2026

Uh oh!

prrace commented Apr 21, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jayathirthrao left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mickleness commented Apr 30, 2026

Uh oh!

openjdk Bot commented Apr 30, 2026

Uh oh!

mickleness commented May 1, 2026

Uh oh!

openjdk Bot commented May 1, 2026

Uh oh!

prrace commented May 4, 2026

Uh oh!

prrace commented May 4, 2026

Uh oh!

openjdk Bot commented May 4, 2026

Uh oh!

openjdk Bot commented May 4, 2026

Uh oh!

openjdk Bot commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

mickleness commented Apr 15, 2026 •

edited by openjdk Bot

Loading

openjdk Bot commented Apr 15, 2026 •

edited

Loading

openjdk Bot commented Apr 15, 2026 •

edited

Loading

mlbridge Bot commented Apr 15, 2026 •

edited

Loading