Skip to content

8381829: Obsolete AggressiveHeap#30768

Closed
jsikstro wants to merge 2 commits intoopenjdk:masterfrom
jsikstro:JDK-8381829_obsolete_aggressiveheap
Closed

8381829: Obsolete AggressiveHeap#30768
jsikstro wants to merge 2 commits intoopenjdk:masterfrom
jsikstro:JDK-8381829_obsolete_aggressiveheap

Conversation

@jsikstro
Copy link
Copy Markdown
Member

@jsikstro jsikstro commented Apr 16, 2026

Hello,

This PR obsoletes the AggressiveHeap flag after being deprecated in JDK26. All changes are straightforward, and we can now simplify Arguments::limit_heap_by_allocatable_memory to only rely on the currently chosen GC, instead of falling back to a seemingly magic number when AggressiveHeap was defined.

Testing:

  • Oracle's tier1-5


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8381829: Obsolete AggressiveHeap (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30768/head:pull/30768
$ git checkout pull/30768

Update a local copy of the PR:
$ git checkout pull/30768
$ git pull https://git.openjdk.org/jdk.git pull/30768/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30768

View PR using the GUI difftool:
$ git pr show -t 30768

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30768.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Apr 16, 2026

👋 Welcome back jsikstro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 16, 2026

@jsikstro This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8381829: Obsolete AggressiveHeap

Reviewed-by: dholmes, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot added the hotspot hotspot-dev@openjdk.org label Apr 16, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 16, 2026

@jsikstro The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Apr 16, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Apr 16, 2026

Webrevs

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 16, 2026

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot. This can be overridden with the /reviewers command.

Copy link
Copy Markdown
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks

@openjdk openjdk Bot added the ready Pull request is ready to be integrated label Apr 22, 2026
@jsikstro
Copy link
Copy Markdown
Member Author

Thank you for the reviews! @dholmes-ora @albertnetymk
/integrate

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 22, 2026

Going to push as commit 7e26bc6.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 21b9a50: 8370102: Print method signatures in edge cases when using TraceBytecodes

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Apr 22, 2026
@openjdk openjdk Bot closed this Apr 22, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 22, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 22, 2026

@jsikstro Pushed as commit 7e26bc6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants