-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8266318: Switch to macos prefix for macOS bundles #3801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back mikael! A progress list of the required criteria for merging this PR into |
Webrevs
|
|
@vidmik This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
Phil, Iris, Erik - thank you for the reviews! /integrate |
|
@vidmik Since your change was applied there have been 14 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 096e9e5. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Apple rebranded the operating system as "macOS" back in 2016. The JDK bundles files are still use the legacy "osx" string. They should be modernized to use "macos" instead.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3801/head:pull/3801$ git checkout pull/3801Update a local copy of the PR:
$ git checkout pull/3801$ git pull https://git.openjdk.java.net/jdk pull/3801/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3801View PR using the GUI difftool:
$ git pr show -t 3801Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3801.diff