Skip to content

8268637: Update --release 17 symbol information for JDK 17 build 28#4641

Closed
jddarcy wants to merge 1 commit intoopenjdk:masterfrom
jddarcy:8268637
Closed

8268637: Update --release 17 symbol information for JDK 17 build 28#4641
jddarcy wants to merge 1 commit intoopenjdk:masterfrom
jddarcy:8268637

Conversation

@jddarcy
Copy link
Member

@jddarcy jddarcy commented Jun 30, 2021

JDK 17 b28 had two fixes which updated the symbol information. A CallerSensitive annotation was removed as part of JDK-8268349 and API changes in JDK-8268888.

These should be reflected in the JDK 18 symbol information for 17.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268637: Update --release 17 symbol information for JDK 17 build 28

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4641/head:pull/4641
$ git checkout pull/4641

Update a local copy of the PR:
$ git checkout pull/4641
$ git pull https://git.openjdk.java.net/jdk pull/4641/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4641

View PR using the GUI difftool:
$ git pr show -t 4641

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4641.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 30, 2021

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 30, 2021
@openjdk
Copy link

openjdk bot commented Jun 30, 2021

@jddarcy The following labels will be automatically applied to this pull request:

  • build
  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org compiler compiler-dev@openjdk.org labels Jun 30, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 30, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 30, 2021

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268637: Update --release 17 symbol information for JDK 17 build 28

Reviewed-by: iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 179 new commits pushed to the master branch:

  • 5c08344: 8269678: Remove unimplemented and unused os::bind_to_processor()
  • 83bce94: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML
  • 1810b1c: 8269516: AArch64: Assembler cleanups
  • a96012a: 8261495: Shenandoah: reconsider update references memory ordering
  • 23d2996: 8269478: Shenandoah: gc/shenandoah/mxbeans tests should be more resilient
  • a6b253d: 8269416: [JVMCI] capture libjvmci crash data to a file
  • a0f32cb: 8268906: gc/g1/mixedgc/TestOldGenCollectionUsage.java assumes that GCs take 1ms minimum
  • ee0247f: 8263461: jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java uses wrong mechanism to cause evacuation failure
  • 3ad20fc: 8269571: NMT should print total malloc bytes and invocation count
  • b969136: 8245877: assert(_value != __null) failed: resolving NULL _value in JvmtiExport::post_compiled_method_load
  • ... and 169 more: https://git.openjdk.java.net/jdk/compare/2d088fa91d18252a801db3b84ff87e261d63ebd4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 30, 2021
@jddarcy
Copy link
Member Author

jddarcy commented Jun 30, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Jun 30, 2021

Going to push as commit 85262c7.
Since your change was applied there have been 179 commits pushed to the master branch:

  • 5c08344: 8269678: Remove unimplemented and unused os::bind_to_processor()
  • 83bce94: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML
  • 1810b1c: 8269516: AArch64: Assembler cleanups
  • a96012a: 8261495: Shenandoah: reconsider update references memory ordering
  • 23d2996: 8269478: Shenandoah: gc/shenandoah/mxbeans tests should be more resilient
  • a6b253d: 8269416: [JVMCI] capture libjvmci crash data to a file
  • a0f32cb: 8268906: gc/g1/mixedgc/TestOldGenCollectionUsage.java assumes that GCs take 1ms minimum
  • ee0247f: 8263461: jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java uses wrong mechanism to cause evacuation failure
  • 3ad20fc: 8269571: NMT should print total malloc bytes and invocation count
  • b969136: 8245877: assert(_value != __null) failed: resolving NULL _value in JvmtiExport::post_compiled_method_load
  • ... and 169 more: https://git.openjdk.java.net/jdk/compare/2d088fa91d18252a801db3b84ff87e261d63ebd4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 30, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 30, 2021
@openjdk
Copy link

openjdk bot commented Jun 30, 2021

@jddarcy Pushed as commit 85262c7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jddarcy jddarcy deleted the 8268637 branch December 9, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build build-dev@openjdk.org compiler compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants