8268284: javax/swing/JComponent/7154030/bug7154030.java fails with "Exception: Failed to hide opaque button" #4792

azuev-java · 2021-07-15T11:27:39Z

Reducing the height of the analyzed area to get rid of the rounded edges
at the botom of the frame. Apparently shadow outside of it being
rendered by Mac OS X Big Sur inconsistently which gives random test
failures on M1 macs with Big Sur.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8268284: javax/swing/JComponent/7154030/bug7154030.java fails with "Exception: Failed to hide opaque button"

Reviewers

Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4792/head:pull/4792
$ git checkout pull/4792

Update a local copy of the PR:
$ git checkout pull/4792
$ git pull https://git.openjdk.java.net/jdk pull/4792/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4792

View PR using the GUI difftool:
$ git pr show -t 4792

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4792.diff

…xception: Failed to hide opaque button" Reducing the height of the analyzed area to get rid of the rounded edges at the botom of the frame. Apparently shadow outside of it being rendered by Mac OS X Big Sur inconsistently which gives random test failures on M1 macs with Big Sur.

bridgekeeper · 2021-07-15T11:28:38Z

👋 Welcome back kizune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-07-15T11:30:49Z

@azuev-java The following label will be automatically applied to this pull request:

swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2021-07-15T11:34:35Z

Webrevs

prsadhuk · 2021-07-15T11:45:55Z

test/jdk/javax/swing/JComponent/7154030/bug7154030.java

            locy = bounds.y + insets.top;
            frw = bounds.width - insets.left - insets.right;
-            frh = bounds.height - insets.top - insets.bottom;
+            frh = bounds.height - insets.top - insets.bottom - 25;


Will making frame undecorated help instead of this?
Can you also please give a CI job running this test on all platforms for several iterations?
Since this test has undergone multiple iterations, can you please confirm that this test still fails without 7154030 fix?

Will making frame undecorated help instead of this?

Yes, seems like making it undecorated fixes the issue. I can not provide many failure results since failures were pretty uncommon in the first place. As for the test run i will add link to it into the bug comment.

gone.

mrserb · 2021-07-17T01:15:45Z

I also suggest to apply some suggestions from here:
#2790 (review)
and use the frame on EDT only, since this is a swing component.

to EDT.

azuev-java · 2021-07-19T19:23:10Z

I also suggest to apply some suggestions from here:
#2790 (review)
and use the frame on EDT only, since this is a swing component.

As i pointed before - after frame is visible taking its coordinates from main thread should not be a problem - in all the cases so far i never had a case where coordinates were miscalculated. But if it makes you happy - it is no harm in moving of this functionality to invokeAndWait block. Here.

mrserb · 2021-07-20T01:00:09Z

after frame is visible taking its coordinates from main thread should not be a problem

It is a problem since these coordinates and other states of the swing components are accessed without any synchronization on the main thread, this can lead to incorrect values being read, it is safe and good to always access Swing on EDT only.

mrserb

Looks fine

openjdk · 2021-07-20T02:45:17Z

@azuev-java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268284: javax/swing/JComponent/7154030/bug7154030.java fails with "Exception: Failed to hide opaque button"

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 78 new commits pushed to the master branch:

00195b8: 8265604: Support unlinked classes in dynamic CDS archive
7f35e5b: 8270869: G1ServiceThread may not terminate
c3519c3: Merge
c130451: 8269752: C2: assert(false) failed: Bad graph detected in build_loop_late
f644365: 8269689: Update --release 17 symbol information for JDK 17 build 31
3fc761d: 8269032: Stringdedup tests are failing if the ergonomically select GC does not support it
a8f1542: 8270455: Remove unused JFR tracer related code in G1CollectedHeap
edff556: 8263385: IGV: Graph is not opened in the window that has focus.
e7cdfeb: 8270862: Fix problem list entries for 32-bit
f8ec3b6: 8270801: Print VM arguments with java -Xlog:arguments
... and 68 more: https://git.openjdk.java.net/jdk/compare/a4e5f08fefac50a1ced7ff4178d9d76f90797949...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

azuev-java · 2021-07-20T03:30:09Z

/integrate

openjdk · 2021-07-20T03:31:31Z

Going to push as commit 534f005.
Since your change was applied there have been 78 commits pushed to the master branch:

00195b8: 8265604: Support unlinked classes in dynamic CDS archive
7f35e5b: 8270869: G1ServiceThread may not terminate
c3519c3: Merge
c130451: 8269752: C2: assert(false) failed: Bad graph detected in build_loop_late
f644365: 8269689: Update --release 17 symbol information for JDK 17 build 31
3fc761d: 8269032: Stringdedup tests are failing if the ergonomically select GC does not support it
a8f1542: 8270455: Remove unused JFR tracer related code in G1CollectedHeap
edff556: 8263385: IGV: Graph is not opened in the window that has focus.
e7cdfeb: 8270862: Fix problem list entries for 32-bit
f8ec3b6: 8270801: Print VM arguments with java -Xlog:arguments
... and 68 more: https://git.openjdk.java.net/jdk/compare/a4e5f08fefac50a1ced7ff4178d9d76f90797949...master

Your commit was automatically rebased without conflicts.

openjdk · 2021-07-20T03:31:50Z

@azuev-java Pushed as commit 534f005.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk bot added the rfr Pull request is ready for review label Jul 15, 2021

openjdk bot added the swing client-libs-dev@openjdk.org label Jul 15, 2021

prsadhuk reviewed Jul 15, 2021

View reviewed changes

Make frame uindecorated - it removes the rounded corners and problem is

e26df3a

gone.

Making location variables volatile and moving frame coordinates request

5cd04bc

to EDT.

mrserb approved these changes Jul 20, 2021

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jul 20, 2021

openjdk bot closed this Jul 20, 2021

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 20, 2021

azuev-java deleted the JDK-8268284 branch April 7, 2022 18:03

openjdk bot added the client client-libs-dev@openjdk.org label Apr 7, 2022

8268284: javax/swing/JComponent/7154030/bug7154030.java fails with "Exception: Failed to hide opaque button" #4792

8268284: javax/swing/JComponent/7154030/bug7154030.java fails with "Exception: Failed to hide opaque button" #4792

Uh oh!

Conversation

azuev-java commented Jul 15, 2021 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Jul 15, 2021

Uh oh!

openjdk bot commented Jul 15, 2021

Uh oh!

mlbridge bot commented Jul 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

prsadhuk Jul 15, 2021

Choose a reason for hiding this comment

Uh oh!

azuev-java Jul 16, 2021

Choose a reason for hiding this comment

Uh oh!

mrserb commented Jul 17, 2021

Uh oh!

azuev-java commented Jul 19, 2021

Uh oh!

mrserb commented Jul 20, 2021

Uh oh!

mrserb left a comment

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Jul 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azuev-java commented Jul 20, 2021

Uh oh!

openjdk bot commented Jul 20, 2021

Uh oh!

openjdk bot commented Jul 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

azuev-java commented Jul 15, 2021 •

edited by openjdk bot

Loading

mlbridge bot commented Jul 15, 2021 •

edited

Loading

openjdk bot commented Jul 20, 2021 •

edited

Loading