-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8272558: IR Test Framework README misses some flags #5138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into |
|
@TobiHartmann The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
chhagedorn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing these. Looks good and trivial!
|
@TobiHartmann This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
Thanks Christian! |
|
/integrate |
|
Going to push as commit 5189047.
Your commit was automatically rebased without conflicts. |
|
@TobiHartmann Pushed as commit 5189047. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The README misses
-DExcludeRandom,-DReportStdoutand-DPreferCommandLineFlags. I also changed-DIgnoreCompilerControls=falseto-DIgnoreCompilerControls=truebecausefalseis the default and added a missingDto-DTestCompilationTimeout.Thanks,
Tobias
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5138/head:pull/5138$ git checkout pull/5138Update a local copy of the PR:
$ git checkout pull/5138$ git pull https://git.openjdk.java.net/jdk pull/5138/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5138View PR using the GUI difftool:
$ git pr show -t 5138Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5138.diff