8210927: JDB tests do not update source path after doing a redefine class

[alexmenkov]

The fix executes "use" jdb command after class redifinition to improve test logs (print correct source line)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8210927: JDB tests do not update source path after doing a redefine class

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5664/head:pull/5664
$ git checkout pull/5664

Update a local copy of the PR:
$ git checkout pull/5664
$ git pull https://git.openjdk.java.net/jdk pull/5664/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5664

View PR using the GUI difftool:
$ git pr show -t 5664

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5664.diff

[bridgekeeper]

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexmenkov The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (31e09f5f)

[sspitsyn]

LGTM

[openjdk]

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8210927: JDB tests do not update source path after doing a redefine class

Reviewed-by: sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 63 new commits pushed to the master branch:

• 56b8b35: 8273261: Replace 'while' cycles with iterator with enhanced-for in java.base
• 0aa63fe: 8274216: ProblemList 2 serviceability/dcmd/gc tests with ZGC on linux-all and windows-all
• 5ffbe75: 8274195: Doc cleanup in java.nio.file
• 1fdc656: 8274175: (fc) java/nio/channels/FileChannel/Transfer2GPlus.java still failed in timeout
• 3b1b8fc: 8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0
• 1b7f4b7: 8274169: HotSpot Style Guide has stale link to chromium style guide
• 653a612: 8270156: Add "randomness" and "stress" keys to JTreg tests which use StressGCM, StressLCM and/or StressIGVN
• 66ce09f: 8272703: StressSeed should be set via FLAG_SET_ERGO
• c434528: 8273546: DecimalFormat documentation contains literal HTML character references
• d098751: 8273916: Remove 'special' ranking
• ... and 53 more: https://git.openjdk.java.net/jdk/compare/5fde4b64e25a3b3a4c01c57064624b9f930a1324...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[plummercj]

Was there a test case failure, or just something you noticed in the log? If a failure, why were no details ever included in the CR. If just something you noticed in the log, can you include the log output and modify a test to show an error?

Would the synopsis be more accurate if it read "do not update the source path ..."?

[alexmenkov]

Was there a test case failure, or just something you noticed in the log? If a failure, why were no details ever included in the CR. If just something you noticed in the log, can you include the log output and modify a test to show an error?

I noticed bad output in test logs.
Added details to the CR.
The test is updated to verify the fix (see uncommented "verifyBPSource(2, bp2Reply);")

Would the synopsis be more accurate if it read "do not update the source path ..."?

Updated the synopsis.

[plummercj]

The test is updated to verify the fix (see uncommented "verifyBPSource(2, bp2Reply);")

Ah, I assume you added and commented out this test case when you first noticed the problem. Makes sense now.

[alexmenkov]

Ah, I assume you added and commented out this test case when you first noticed the problem. Makes sense now.

That's right. Sorry I was not clear enough.

[alexmenkov]

/integrate

[openjdk]

Going to push as commit 61ac53f.
Since your change was applied there have been 79 commits pushed to the master branch:

• 341de49: 8273492: Move evacuation failure handling into G1YoungCollector
• 13e9ea9: 8273297: AES/GCM non-AVX512+VAES CPUs suffer after 8267125
• 753b256: 8274296: Update or Problem List tests which may fail with uiScale=2 on macOS
• baafa60: 8274237: Replace 'for' cycles with iterator with enhanced-for in java.base
• 0c050be: 8274294: ProblemList sun/tools/jmap/BasicJMapTest.java
• e741a18: 8274233: Minor cleanup for ToolBox
• 718eff2: 8273380: ARM32: Default to {ldrexd,strexd} in StubRoutines::atomic_{load|store}_long
• f214d6e: 8274234: Remove unnecessary boxing via primitive wrapper valueOf(String) methods in java.sql.rowset
• f36a2bb: 8274087: Windows DLL path not set correctly.
• 5ba0d09: 8274205: Handle KDC_ERR_SVC_UNAVAILABLE error code from KDC
• ... and 69 more: https://git.openjdk.java.net/jdk/compare/5fde4b64e25a3b3a4c01c57064624b9f930a1324...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexmenkov Pushed as commit 61ac53f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.