Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278310: Improve logging in CDS #6756


Copy link

@calvinccheung calvinccheung commented Dec 8, 2021

A simple change to add more logging in the test.

Ran the test on linux-x64 to make sure CDS debug logging is in the output files.


  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed


  • JDK-8278310: Improve logging in CDS



Using git

Checkout this PR locally:
$ git fetch pull/6756/head:pull/6756
$ git checkout pull/6756

Update a local copy of the PR:
$ git checkout pull/6756
$ git pull pull/6756/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6756

View PR using the GUI difftool:
$ git pr show -t 6756

Using diff file

Download this PR as a diff file:

Copy link
Member Author

@calvinccheung calvinccheung commented Dec 8, 2021

/label add hotspot-runtime

Copy link

@bridgekeeper bridgekeeper bot commented Dec 8, 2021

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the hotspot-runtime label Dec 8, 2021
Copy link

@openjdk openjdk bot commented Dec 8, 2021

The hotspot-runtime label was successfully added.

@calvinccheung calvinccheung marked this pull request as ready for review Dec 8, 2021
@openjdk openjdk bot added the rfr label Dec 8, 2021
Copy link

@mlbridge mlbridge bot commented Dec 8, 2021


iklam approved these changes Dec 8, 2021
Copy link

@iklam iklam left a comment

Looks good. I think this can be considered as a trivial change.

Copy link

@openjdk openjdk bot commented Dec 8, 2021

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file for details.

After integration, the commit message for the final commit will be:

8278310: Improve logging in CDS

Reviewed-by: iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

  • e7db581: 8277168: AArch64: Enable arraycopy partial inlining with SVE
  • fb6d611: 8278276: G1: Refine naming of G1GCParPhaseTimesTracker::_must_record
  • d7ad546: 8276422: Add command-line option to disable finalization
  • ec7cb6d: 8276447: Deprecate finalization-related methods for removal
  • 3c2951f: 8275771: JDK source code contains redundant boolean operations in jdk.compiler and langtools
  • 3d61372: 8278363: Create extented container test groups
  • 716c2e1: 8278368: ProblemList tools/jpackage/share/ on macosx-x64
  • a8a1fbc: 8278068: Fix next-line modifier (snippet markup)
  • 061017a: 8273175: Add @SInCE tags to the DocTree.Kind enum constants
  • d7c283a: 8275233: Incorrect line number reported in exception stack trace thrown from a lambda expression
  • ... and 17 more:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 8, 2021
Copy link
Member Author

@calvinccheung calvinccheung commented Dec 8, 2021

Thanks @iklam for the review.

Copy link

@openjdk openjdk bot commented Dec 8, 2021

Going to push as commit 40d726b.
Since your change was applied there have been 37 commits pushed to the master branch:

  • e4852c6: 8277998: runtime/cds/appcds/loaderConstraints/ failed "assert(ZAddress::is_marked(addr)) failed: Should be marked"
  • 37921e3: 8269258: java/net/httpclient/ failed with connection timeout
  • fd8cb2d: 8278346: java/nio/file/Files/probeContentType/ fails on Linux SLES15 machine
  • e5cb84e: 8278336: Use int64_t to represent byte quantities consistently in JfrObjectAllocationSample
  • 54993b1: 8278309: [windows] use of uninitialized OSThread::_state
  • 10e0318: 8278158: jwebserver should set request timeout
  • 5dcdee4: 8262341: Refine identical code in AddI/LNode.
  • b334d96: 8276964: Better indicate a snippet that could not be processed
  • 30f0c64: 8277992: Add fast jdk_svc subtests to jdk:tier3
  • 5266e7d: 8278379: Zero VM is broken due to UseRTMForStackLocks was not declared after JDK-8276901
  • ... and 27 more:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 8, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 8, 2021
Copy link

@openjdk openjdk bot commented Dec 8, 2021

@calvinccheung Pushed as commit 40d726b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@calvinccheung calvinccheung deleted the 8278310-improve-logging-DynamicLoaderConstraintsTest branch Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
hotspot-runtime integrated
2 participants