Skip to content

Conversation

@calvinccheung
Copy link
Member

@calvinccheung calvinccheung commented Dec 8, 2021

A simple change to add more logging in the DynamicLoaderConstraintsTest.java test.

Ran the test on linux-x64 to make sure CDS debug logging is in the output files.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278310: Improve logging in CDS DynamicLoaderConstraintsTest.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6756/head:pull/6756
$ git checkout pull/6756

Update a local copy of the PR:
$ git checkout pull/6756
$ git pull https://git.openjdk.java.net/jdk pull/6756/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6756

View PR using the GUI difftool:
$ git pr show -t 6756

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6756.diff

@calvinccheung
Copy link
Member Author

/label add hotspot-runtime

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 8, 2021

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Dec 8, 2021
@openjdk
Copy link

openjdk bot commented Dec 8, 2021

@calvinccheung
The hotspot-runtime label was successfully added.

@calvinccheung calvinccheung marked this pull request as ready for review December 8, 2021 02:35
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 8, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 8, 2021

Webrevs

Copy link
Member

@iklam iklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think this can be considered as a trivial change.

@openjdk
Copy link

openjdk bot commented Dec 8, 2021

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278310: Improve logging in CDS DynamicLoaderConstraintsTest.java

Reviewed-by: iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 8, 2021
@calvinccheung
Copy link
Member Author

Thanks @iklam for the review.
/integrate

@openjdk
Copy link

openjdk bot commented Dec 8, 2021

Going to push as commit 40d726b.
Since your change was applied there have been 37 commits pushed to the master branch:

  • e4852c6: 8277998: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java#custom-cl-zgc failed "assert(ZAddress::is_marked(addr)) failed: Should be marked"
  • 37921e3: 8269258: java/net/httpclient/ManyRequestsLegacy.java failed with connection timeout
  • fd8cb2d: 8278346: java/nio/file/Files/probeContentType/Basic.java fails on Linux SLES15 machine
  • e5cb84e: 8278336: Use int64_t to represent byte quantities consistently in JfrObjectAllocationSample
  • 54993b1: 8278309: [windows] use of uninitialized OSThread::_state
  • 10e0318: 8278158: jwebserver should set request timeout
  • 5dcdee4: 8262341: Refine identical code in AddI/LNode.
  • b334d96: 8276964: Better indicate a snippet that could not be processed
  • 30f0c64: 8277992: Add fast jdk_svc subtests to jdk:tier3
  • 5266e7d: 8278379: Zero VM is broken due to UseRTMForStackLocks was not declared after JDK-8276901
  • ... and 27 more: https://git.openjdk.java.net/jdk/compare/f22d157e551fb28991e7713a45e63a0a8d9d2c4c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 8, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 8, 2021
@openjdk
Copy link

openjdk bot commented Dec 8, 2021

@calvinccheung Pushed as commit 40d726b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@calvinccheung calvinccheung deleted the 8278310-improve-logging-DynamicLoaderConstraintsTest branch December 8, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants