-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8278310: Improve logging in CDS DynamicLoaderConstraintsTest.java #6756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8278310: Improve logging in CDS DynamicLoaderConstraintsTest.java #6756
Conversation
|
/label add hotspot-runtime |
|
👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into |
|
@calvinccheung |
iklam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think this can be considered as a trivial change.
|
@calvinccheung This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 27 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
Thanks @iklam for the review. |
|
Going to push as commit 40d726b.
Your commit was automatically rebased without conflicts. |
|
@calvinccheung Pushed as commit 40d726b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
A simple change to add more logging in the DynamicLoaderConstraintsTest.java test.
Ran the test on linux-x64 to make sure CDS debug logging is in the output files.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6756/head:pull/6756$ git checkout pull/6756Update a local copy of the PR:
$ git checkout pull/6756$ git pull https://git.openjdk.java.net/jdk pull/6756/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6756View PR using the GUI difftool:
$ git pr show -t 6756Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6756.diff