JDK-8279641: Create manual JTReg tests for Swing accessibility

[shurymury]

Tests are based on SwingSet2 application.
Test instructions are loaded from HTML files.

See readme for more info.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8279641: Create manual JTReg tests for Swing accessibility

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)
• Phil Race (@prrace - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6993/head:pull/6993
$ git checkout pull/6993

Update a local copy of the PR:
$ git checkout pull/6993
$ git pull https://git.openjdk.java.net/jdk pull/6993/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6993

View PR using the GUI difftool:
$ git pr show -t 6993

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6993.diff

[bridgekeeper]

👋 Welcome back shurailine! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shurymury The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (7dd884ae)

[shurymury]

@prrace Can you take a look?

[mrserb]

An initial question, which look and feel are we expected to test? Do we need to cover the default one, or it is up to someone to pass the correct L&F?

[prrace]

An initial question, which look and feel are we expected to test? Do we need to cover the default one, or it is up to someone to pass the correct L&F?

Need in what context ? Who is "we" ?
Test which ever L&Fs your distro wants to certify as accessible. It isn't like a TCK test.
It is optional as far as JDK is concerned but maybe not for some hypothetical consumer of your release.

[shurymury]

An initial question, which look and feel are we expected to test? Do we need to cover the default one, or it is up to someone to pass the correct L&F?

This current implementation does not do anything to support different LAFs.

A test executor can still specify the LAF through -vmoption:"-Dswing.defaultlaf=..." JTReg option.

[mrserb]

This current implementation does not do anything to support different LAFs.

Even if the tests do nothing it is expected that these tests will pass on the default L&Fs like Aqua/Metal. If it is expected to pass on all L&F why not iterate over all installed L&F and prove that?

BTW I am not sure that the metal l&f will work properly on macOS, does anybody test a11y for it?

[shurymury]

This current implementation does not do anything to support different LAFs.

Even if the tests do nothing it is expected that these tests will pass on the default L&Fs like Aqua/Metal. If it is expected to pass on all L&F why not iterate over all installed L&F and prove that?

Changes suggested by this review only cover default LAF by default, unless LAF is specified explicitly. There may be improvements later which would suggest rotating LAFs, that would be a subject of a follow-up reviews.

[openjdk]

@shurymury This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279641: Create manual JTReg tests for Swing accessibility

Reviewed-by: serb, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 155 new commits pushed to the master branch:

• dac15ef: 8280182: HotSpot Style Guide has stale link to chromium style guide
• 84fa0d8: 8190264: JScrollBar ignores its border when using macOS Mac OS X Aqua look and feel
• 610a129: 8268831: Improve javadoc tool handling of streams.
• e20c6bf: 8280189: JFR: TestPrintXML should print mismatching XML
• b20b11c: 8258240: make vscode-project on Windows generates jdk.code-workspace file with unescaped '' in paths
• 9611431: 8279936: Change shared code to use os:: system API's
• cc2f474: 8280024: Parallel: Remove unnecessary region resizing methods in PSCardTable
• 8931c12: 8280157: wrong texts Falied in a couple of tests
• 68b40ec: 8273139: C2: assert(f <= 1 && f >= 0) failed: Incorrect frequency
• 39b1d75: 8277822: Remove debug-only heap overrun checks in os::malloc and friends
• ... and 145 more: https://git.openjdk.java.net/jdk/compare/d47af74e4c98c9fc4aef537c6d8eeb66a1621586...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shurymury]

/integrate

[openjdk]

Going to push as commit 5523dde.
Since your change was applied there have been 155 commits pushed to the master branch:

• dac15ef: 8280182: HotSpot Style Guide has stale link to chromium style guide
• 84fa0d8: 8190264: JScrollBar ignores its border when using macOS Mac OS X Aqua look and feel
• 610a129: 8268831: Improve javadoc tool handling of streams.
• e20c6bf: 8280189: JFR: TestPrintXML should print mismatching XML
• b20b11c: 8258240: make vscode-project on Windows generates jdk.code-workspace file with unescaped '' in paths
• 9611431: 8279936: Change shared code to use os:: system API's
• cc2f474: 8280024: Parallel: Remove unnecessary region resizing methods in PSCardTable
• 8931c12: 8280157: wrong texts Falied in a couple of tests
• 68b40ec: 8273139: C2: assert(f <= 1 && f >= 0) failed: Incorrect frequency
• 39b1d75: 8277822: Remove debug-only heap overrun checks in os::malloc and friends
• ... and 145 more: https://git.openjdk.java.net/jdk/compare/d47af74e4c98c9fc4aef537c6d8eeb66a1621586...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shurymury Pushed as commit 5523dde.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.