Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282548: Create a regression test for JEditorPane.setText(null) usecase #7740

Closed
wants to merge 5 commits into from

Conversation

manukumarvs
Copy link
Member

@manukumarvs manukumarvs commented Mar 8, 2022

Create a regression test for JDK-4330998

Issue tested:
When calling JEditorPane.setText(null), the following exception is thrown:

java.lang.NullPointerException:
at java.io.StringReader.(StringReader.java:38)

Testing:
Java 1.4.0 -> Test Failed.
$ ./j2sdk1.4.0/bin/java bug4330998Win
java.lang.RuntimeException: Test failed, caught Exception java.lang.NullPointerException when calling text.setText(null)
at bug4330998Win.runTest(bug4330998Win.java:45)
at bug4330998Win.main(bug4330998Win.java:51)
Exception in thread "main"

Java 1.4.1 -> Test Passed.
$ ./j2sdk1.4.1/bin/java bug4330998Win
Test passed


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8282548: Create a regression test for JDK-4330998

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7740/head:pull/7740
$ git checkout pull/7740

Update a local copy of the PR:
$ git checkout pull/7740
$ git pull https://git.openjdk.java.net/jdk pull/7740/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7740

View PR using the GUI difftool:
$ git pr show -t 7740

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7740.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 8, 2022

👋 Welcome back mvs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 8, 2022
@openjdk
Copy link

openjdk bot commented Mar 8, 2022

@manukumarvs The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 8, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 8, 2022

Webrevs

@manukumarvs
Copy link
Member Author

@aivanov-jdk Can you please review this.

@manukumarvs
Copy link
Member Author

Any volunteers?

@openjdk openjdk bot removed the rfr Pull request is ready for review label Mar 16, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 16, 2022
@openjdk
Copy link

openjdk bot commented Mar 16, 2022

@manukumarvs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282548: Create a regression test for JDK-4330998

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 323 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 16, 2022
@manukumarvs
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 16, 2022
@openjdk
Copy link

openjdk bot commented Mar 16, 2022

@manukumarvs
Your change (at version 03d7475) is now ready to be sponsored by a Committer.

@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label Mar 17, 2022
@manukumarvs
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 17, 2022
@openjdk
Copy link

openjdk bot commented Mar 17, 2022

@manukumarvs
Your change (at version 954e8f0) is now ready to be sponsored by a Committer.

@aivanov-jdk
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 21, 2022

Going to push as commit b451273.
Since your change was applied there have been 343 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 21, 2022
@openjdk openjdk bot closed this Mar 21, 2022
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Mar 21, 2022
@openjdk openjdk bot removed rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 21, 2022
@openjdk
Copy link

openjdk bot commented Mar 21, 2022

@aivanov-jdk @manukumarvs Pushed as commit b451273.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@manukumarvs manukumarvs deleted the 8282548 branch May 4, 2022 07:49
@manukumarvs manukumarvs changed the title 8282548: Create a regression test for JDK-4330998 8282548: Create a regression test for JEditorPane.setText(null) usecase Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants