8283279: [Testbug] Improve TestGetSwapSpaceSize

[jerboaa]

Please review this container test improvement. The test in question only makes sense iff the total swap space size as reported by the container aware OperatingSystemMXBean is 0. If that's not the case, then something else might be amiss, e.g. OperatingSystemMXBean reporting the host swap limits. In such a case a passing test tells us nothing. Certainly not if the
fix from JDK-8242480 is present or not.

Testing:

• Manual with and without the code fix of JDK-8242480. Still passes with the fix, and fails without. Tested the test on cgroups v1 and cgroups v2.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8283279: [Testbug] Improve TestGetSwapSpaceSize

Reviewers

• Jie Fu (@DamonFool - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7854/head:pull/7854
$ git checkout pull/7854

Update a local copy of the PR:
$ git checkout pull/7854
$ git pull https://git.openjdk.java.net/jdk pull/7854/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7854

View PR using the GUI difftool:
$ git pr show -t 7854

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7854.diff

[jerboaa]

/label core-libs

[bridgekeeper]

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jerboaa
The core-libs label was successfully added.

[mlbridge]

Webrevs

• 01: Full - Incremental (891c2366)
• 00: Full (1bbb550a)

[jerboaa]

@DamonFool Do you think you can have a look at this? Thanks!

[plummercj]

/label serviceability

[openjdk]

@plummercj
The serviceability label was successfully added.

[DamonFool]

Please also update the copyright year.
Thanks.

[jerboaa]

Thanks for the review, @DamonFool! Updated the patch.

[DamonFool]

LGTM
Thanks for the update.

[openjdk]

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283279: [Testbug] Improve TestGetSwapSpaceSize

Reviewed-by: jiefu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

• 6ed0ba2: 8283543: indentation error at com.sun.tools.javac.comp.Enter::visitTopLevel
• 91fab6a: 8283411: InflaterInputStream holds on to a temporary byte array of 512 bytes
• d8c5572: 8282204: Use lea instructions for arithmetic operations on x86_64
• 026b853: 8283298: Make CodeCacheSegmentSize a product flag
• 58487dd: 8283249: CompressedClassPointers.java fails on ppc with 'Narrow klass shift: 0' missing
• 86015e1: 8282293: Domain value for system property jdk.https.negotiate.cbt should be case-insensitive
• 1443f6b: 8283199: Linux os::cpu_microcode_revision() stalls cold startup
• 82e1a1c: 8283257: x86: Clean up invocation/branch counter updates code
• b035fda: 8283497: [windows] print TMP and TEMP in hs_err and VM.info
• 6ea996c: 8282422: JTable.print() failed with UnsupportedCharsetException on AIX ko_KR locale
• ... and 19 more: https://git.openjdk.java.net/jdk/compare/cb576da575ea3c8f14087dd312313843764ca2f4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jerboaa]

Thanks for the review!

[jerboaa]

/integrate

[openjdk]

Going to push as commit a771600.
Since your change was applied there have been 33 commits pushed to the master branch:

• 2b291d8: 8282536: java.net.InetAddress should be a sealed class
• dc45b0a: 8283513: Parallel: Skip the card marking in PSRootsClosure
• 78ef2fd: 8283562: JDK-8282306 breaks gtests on zero
• 61d7d86: 8283254: Remove redundant class jdk/internal/agent/spi/AgentProvider
• 6ed0ba2: 8283543: indentation error at com.sun.tools.javac.comp.Enter::visitTopLevel
• 91fab6a: 8283411: InflaterInputStream holds on to a temporary byte array of 512 bytes
• d8c5572: 8282204: Use lea instructions for arithmetic operations on x86_64
• 026b853: 8283298: Make CodeCacheSegmentSize a product flag
• 58487dd: 8283249: CompressedClassPointers.java fails on ppc with 'Narrow klass shift: 0' missing
• 86015e1: 8282293: Domain value for system property jdk.https.negotiate.cbt should be case-insensitive
• ... and 23 more: https://git.openjdk.java.net/jdk/compare/cb576da575ea3c8f14087dd312313843764ca2f4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa Pushed as commit a771600.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.