8144030: [macosx] test java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails (again)

[azvegint]

This test has two undecorated frames:

1. background, 300x300
2. shaped foreground, 200x200

After displaying this frames it tries to check color outside of shape but within frame 2 bounds.

Unfortunately, on Linux and macOS there is a shadow around the shaped frame:

(changed color to green to make it more noticeable).

One way to fix the test would be to add tolerance to color check.
But with old check points blue color may vary in 222-255 range, which is a bit too much.

Instead of this I made this shaped window the size of background window.
This allows us to move check points away from shape border and its shadow, but still be able to check whether shape is applied or not.

Testing is green on all platforms.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8144030: [macosx] test java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails (again)

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8233/head:pull/8233
$ git checkout pull/8233

Update a local copy of the PR:
$ git checkout pull/8233
$ git pull https://git.openjdk.java.net/jdk pull/8233/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8233

View PR using the GUI difftool:
$ git pr show -t 8233

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8233.diff

[bridgekeeper]

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[azvegint]

Dunno why the old version was not checking inner points, but I've added one just to check if the shaped frame is above background one.

[mrserb]

Don't we need to check the places where the shadow is rendered that it is not the shape color(to prove that the shape is not simple rectangular)?

[azvegint]

Sure, extra check added.

[openjdk]

@azvegint The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (dbef3618)
• 00: Full (d169081d)

[openjdk]

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8144030: [macosx] test java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails (again)

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• c3938ec: 8159694: HiDPI, Unity, java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java
• 23c6817: 6626492: Event time in future part 2, now on X
• 2241a05: 8284578: Relax InterpreterCodelet stub alignment
• bf85b00: 8284564: Extend VectorAPI validation tests for SHIFTs and ROTATE operations with constant shift values.

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[azvegint]

/integrate

[openjdk]

Going to push as commit e5041ae.
Since your change was applied there have been 31 commits pushed to the master branch:

• f5beafa: 8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java
• 21de4e5: 8284681: compiler/c2/aarch64/TestFarJump.java fails with "RuntimeException: for CodeHeap < 250MB the far jump is expected to be encoded with a single branch instruction"
• 9695283: 8240903: Add test to check that jmod hashes are reproducible
• dce7240: 8284921: tier1 test failures after JDK-8284909
• 9f97f5d: 8283704: Add sealed modifier to java.awt.MultipleGradientPaint
• 1ebf2f0: 8284909: [JVMCI] remove remnants of AOT support
• 6199008: 8284914: Problem list test(s) failing due to extra repaints with D3D pipeline.
• 4cc8ecc: 8280915: Better parallelization for AbstractSpliterator and IteratorSpliterator when size is unknown
• 53580b3: 8284884: Replace polling with waiting in javax/swing/text/html/parser/Parser/8078268/bug8078268.java
• bdf8a2a: 8283326: Implement SafeFetch statically
• ... and 21 more: https://git.openjdk.java.net/jdk/compare/bf1c3ef02b22a615101530642d245fef899d33b7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@azvegint Pushed as commit e5041ae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.