Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285686: Upgrade to FreeType 2.12.0 #8456

Closed
wants to merge 1 commit into from

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Apr 28, 2022

This upgrades the JDK from using freetype 2.10.4 to 2.12.0
Automated tests pass, manual testing looks fine.
--with-freetype=bundled was used to make sure it is OK on Linux builds.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8456/head:pull/8456
$ git checkout pull/8456

Update a local copy of the PR:
$ git checkout pull/8456
$ git pull https://git.openjdk.java.net/jdk pull/8456/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8456

View PR using the GUI difftool:
$ git pr show -t 8456

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8456.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 28, 2022

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8285686 8285686: Upgrade to FreeType 2.12.0 Apr 28, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 28, 2022
@openjdk
Copy link

openjdk bot commented Apr 28, 2022

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 28, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 28, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 28, 2022

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285686: Upgrade to FreeType 2.12.0

Reviewed-by: serb, jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

  • e406662: 8282711: Accelerate Math.signum function for AVX and AVX512 target.
  • 0a4a640: 8285301: C2: assert(!requires_atomic_access) failed: can't ensure atomicity
  • 40f19c0: 8264666: Change implementation of safeAdd/safeMult in the LCMSImageLayout class
  • 1e28fcb: 8155701: The compiler fails with an AssertionError: typeSig ERROR
  • 99388ef: 8283624: Create an automated regression test for RFE-4390885
  • 94b533a: 8285699: riscv: Provide information when hitting a HaltNode
  • e2e943a: 8285688: Add links to JEPs and JSRs to SourceVersion
  • 80cf59f: 8285610: TreeInfo.pathFor and its uses appear to be dead code
  • 21b62fe: 8195589: T6587786.java failed after JDK-8189997
  • 8190217: 8285496: DocLint does not check for missing @param tags for type parameters on classes and interfaces
  • ... and 21 more: https://git.openjdk.java.net/jdk/compare/8a16842b4e906b2eede0c01914f41010cabc51c2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 28, 2022
@prrace
Copy link
Contributor Author

prrace commented Apr 29, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Apr 29, 2022

Going to push as commit 67dd8a8.
Since your change was applied there have been 41 commits pushed to the master branch:

  • 64225e1: 8285919: Remove debug printout from JDK-8285093
  • df4d5cf: 8285802: AArch64: Consistently handle offsets in MacroAssembler as 64-bit quantities
  • 694556e: 8225433: Clarify behavior of PKIXParameters.setRevocationEnabled when PKIXRevocationChecker is used
  • e98ac23: 8285793: C2: optimization of mask checks in counted loops fail in the presence of cast nodes
  • 669ac61: 8274597: Some of the dnd tests time out and fail intermittently
  • 269eae6: 8285515: (dc) DatagramChannel.disconnect fails with "Invalid argument" on macOS 12.4 beta2
  • c4f7a85: 8285828: runtime/execstack/TestCheckJDK.java fails with zipped debug symbols
  • d3606a3: 8285390: PPC64: Handle integral division overflow during parsing
  • f42631e: 8285523: Improve test java/io/FileOutputStream/OpenNUL.java
  • b71e8c1: 8285711: riscv: RVC: Support disassembler show-bytes option
  • ... and 31 more: https://git.openjdk.java.net/jdk/compare/8a16842b4e906b2eede0c01914f41010cabc51c2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 29, 2022
@openjdk openjdk bot closed this Apr 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 29, 2022
@openjdk
Copy link

openjdk bot commented Apr 29, 2022

@prrace Pushed as commit 67dd8a8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants